Skip to content

Commit 0bc4ff6

Browse files
committed
fixing proper use of exp in generateKeyPair(b, exp) and tests
1 parent b68b923 commit 0bc4ff6

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

src/NodeRSA.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ module.exports = (function() {
4545
*/
4646
NodeRSA.prototype.generateKeyPair = function(bits, exp) {
4747
bits = bits || 2048;
48-
exp = 65537;
48+
exp = exp || 65537;
4949

50-
if (bits % 8 != 0) {
50+
if (bits % 8 !== 0) {
5151
throw Error('Key size must be a multiple of 8.');
5252
}
5353

test/tests.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,17 @@ describe("NodeRSA", function(){
6060
describe("Generating keys", function() {
6161
for (var size in keySizes) {
6262
(function(size){
63-
it("should make key pair " + size.b + "-bit length and public exponent is " + (size.e || 65537), function () {
63+
it("should make key pair " + size.b + "-bit length and public exponent is " + size.e, function () {
6464
generatedKeys.push(new NodeRSA({b: size.b, e: size.e}));
6565
assert.instanceOf(generatedKeys[generatedKeys.length - 1].keyPair, Object);
66+
67+
if (size.e != null && size.e != undefined)
68+
{
69+
assert.equal(generatedKeys[generatedKeys.length - 1].keyPair.e, size.e);
70+
} else {
71+
assert.equal(generatedKeys[generatedKeys.length - 1].keyPair.e, 65537);
72+
}
73+
6674
assert.equal(generatedKeys[generatedKeys.length - 1].getKeySize(), size.b);
6775
assert.equal(generatedKeys[generatedKeys.length - 1].getMaxMessageSize(), (size.b / 8 - 11));
6876
});

0 commit comments

Comments
 (0)