Skip to content

Commit 52e3dfd

Browse files
committed
Test: Add lint to allow deprecated members in tests. Remove old TODOs
1 parent e692455 commit 52e3dfd

File tree

2 files changed

+9
-26
lines changed

2 files changed

+9
-26
lines changed

test/flex_seed_scheme_test.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ void main() {
3434
final ColorScheme flex = SeedColorScheme.fromSeeds(
3535
brightness: Brightness.light,
3636
primaryKey: primarySeedColor,
37+
// ignore: deprecated_member_use, for testing, still used in SDK.
3738
).copyWith(surfaceVariant: flutter.surfaceVariant);
3839

3940
expect(
@@ -57,6 +58,7 @@ void main() {
5758
final ColorScheme flex = SeedColorScheme.fromSeeds(
5859
brightness: Brightness.dark,
5960
primaryKey: primarySeedColor,
61+
// ignore: deprecated_member_use, for testing, still used in SDK.
6062
).copyWith(surfaceVariant: flutter.surfaceVariant);
6163

6264
expect(

test/mcu/dynamic_scheme_test.dart

Lines changed: 7 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ void main() {
106106
// TODO(rydmike): This test cannot pass until Flutter updates to MCU 0.12.0
107107
// expect(colorScheme.onPrimaryContainer.value32bit,
108108
// MaterialDynamicColors.onPrimaryContainer.getArgb(dynamicScheme));
109-
// TODO(rydmike): Using hard coded value test until Flutter updates.
109+
// TODO(rydmike): Using temp hard coded value test until Flutter updates.
110110
expect(colorScheme.onPrimaryContainer.value32bit, 4281079296);
111111
//
112112
expect(colorScheme.primaryFixed.value32bit,
@@ -125,10 +125,6 @@ void main() {
125125
MaterialDynamicColors.secondaryContainer.getArgb(dynamicScheme));
126126
expect(colorScheme.onSecondaryContainer.value32bit,
127127
MaterialDynamicColors.onSecondaryContainer.getArgb(dynamicScheme));
128-
// TODO(rydmike): Use hard coded values to test expressive colors
129-
// expect(colorScheme.onSecondaryContainer.value32bit, 4280883206);
130-
// expect(4284039724,
131-
// MaterialDynamicColors.onSecondaryContainer.getArgb(dynamicScheme));
132128
//
133129
expect(colorScheme.secondaryFixed.value32bit,
134130
MaterialDynamicColors.secondaryFixed.getArgb(dynamicScheme));
@@ -146,10 +142,6 @@ void main() {
146142
MaterialDynamicColors.tertiaryContainer.getArgb(dynamicScheme));
147143
expect(colorScheme.onTertiaryContainer.value32bit,
148144
MaterialDynamicColors.onTertiaryContainer.getArgb(dynamicScheme));
149-
// TODO(rydmike): Use hard coded values to test expressive colors
150-
// expect(colorScheme.onTertiaryContainer.value32bit, 4279639553);
151-
// expect(4282469156,
152-
// MaterialDynamicColors.onTertiaryContainer.getArgb(dynamicScheme));
153145
//
154146
expect(colorScheme.tertiaryFixed.value32bit,
155147
MaterialDynamicColors.tertiaryFixed.getArgb(dynamicScheme));
@@ -167,13 +159,11 @@ void main() {
167159
MaterialDynamicColors.errorContainer.getArgb(dynamicScheme));
168160
expect(colorScheme.onErrorContainer.value32bit,
169161
MaterialDynamicColors.onErrorContainer.getArgb(dynamicScheme));
170-
// TODO(rydmike): Use hard coded values to test expressive colors
171-
// expect(colorScheme.onErrorContainer.value32bit, 4282449922);
172-
// expect(4287823882,
173-
// MaterialDynamicColors.onErrorContainer.getArgb(dynamicScheme));
174162
//
163+
// ignore: deprecated_member_use, for testing, still used in SDK.
175164
expect(colorScheme.background.value32bit,
176165
MaterialDynamicColors.background.getArgb(dynamicScheme));
166+
// ignore: deprecated_member_use, for testing, still used in SDK.
177167
expect(colorScheme.onBackground.value32bit,
178168
MaterialDynamicColors.onBackground.getArgb(dynamicScheme));
179169
expect(colorScheme.surface.value32bit,
@@ -194,6 +184,7 @@ void main() {
194184
MaterialDynamicColors.surfaceContainerHighest.getArgb(dynamicScheme));
195185
expect(colorScheme.onSurface.value32bit,
196186
MaterialDynamicColors.onSurface.getArgb(dynamicScheme));
187+
// ignore: deprecated_member_use, for testing, still used in SDK.
197188
expect(colorScheme.surfaceVariant.value32bit,
198189
MaterialDynamicColors.surfaceVariant.getArgb(dynamicScheme));
199190
expect(colorScheme.onSurfaceVariant.value32bit,
@@ -220,9 +211,6 @@ void main() {
220211
dynamicScheme.primaryContainer);
221212
expect(colorScheme.onPrimaryContainer.value32bit,
222213
dynamicScheme.onPrimaryContainer);
223-
// TODO(rydmike): Use hard coded values to test expressive colors
224-
// expect(colorScheme.onPrimaryContainer.value32bit, 4281079296);
225-
// expect(4285086720, dynamicScheme.onPrimaryContainer);
226214
//
227215
expect(colorScheme.primaryFixed.value32bit, dynamicScheme.primaryFixed);
228216
expect(
@@ -236,9 +224,6 @@ void main() {
236224
dynamicScheme.secondaryContainer);
237225
expect(colorScheme.onSecondaryContainer.value32bit,
238226
dynamicScheme.onSecondaryContainer);
239-
// TODO(rydmike): Use hard coded values to test expressive colors
240-
// expect(colorScheme.onSecondaryContainer.value32bit, 4280883206);
241-
// expect(4284039724, dynamicScheme.onSecondaryContainer);
242227
//
243228
expect(colorScheme.secondaryFixed.value32bit, dynamicScheme.secondaryFixed);
244229
expect(colorScheme.secondaryFixedDim.value32bit,
@@ -253,9 +238,6 @@ void main() {
253238
dynamicScheme.tertiaryContainer);
254239
expect(colorScheme.onTertiaryContainer.value32bit,
255240
dynamicScheme.onTertiaryContainer);
256-
// TODO(rydmike): Use hard coded values to test expressive colors
257-
// expect(colorScheme.onTertiaryContainer.value32bit, 4279639553);
258-
// expect(4282469156, dynamicScheme.onTertiaryContainer);
259241
//
260242
expect(colorScheme.tertiaryFixed.value32bit, dynamicScheme.tertiaryFixed);
261243
expect(colorScheme.tertiaryFixedDim.value32bit,
@@ -269,11 +251,9 @@ void main() {
269251
expect(colorScheme.errorContainer.value32bit, dynamicScheme.errorContainer);
270252
expect(colorScheme.onErrorContainer.value32bit,
271253
dynamicScheme.onErrorContainer);
272-
// TODO(rydmike): Use hard coded values to test expressive colors
273-
// expect(colorScheme.onErrorContainer.value32bit, 4282449922);
274-
// expect(4287823882, dynamicScheme.onErrorContainer);
275-
//
254+
// ignore: deprecated_member_use, for testing, still used in SDK.
276255
expect(colorScheme.background.value32bit, dynamicScheme.background);
256+
// ignore: deprecated_member_use, for testing, still used in SDK.
277257
expect(colorScheme.onBackground.value32bit, dynamicScheme.onBackground);
278258
expect(colorScheme.surface.value32bit, dynamicScheme.surface);
279259
expect(colorScheme.surfaceDim.value32bit, dynamicScheme.surfaceDim);
@@ -289,6 +269,7 @@ void main() {
289269
expect(colorScheme.surfaceContainerHighest.value32bit,
290270
dynamicScheme.surfaceContainerHighest);
291271
expect(colorScheme.onSurface.value32bit, dynamicScheme.onSurface);
272+
// ignore: deprecated_member_use, for testing, still used in SDK.
292273
expect(colorScheme.surfaceVariant.value32bit, dynamicScheme.surfaceVariant);
293274
expect(colorScheme.onSurfaceVariant.value32bit,
294275
dynamicScheme.onSurfaceVariant);

0 commit comments

Comments
 (0)