Merge pull request #320 from fox0/clippy--needless_range_loop

jgarzik · web-flow · commit 199f206bf97a · 2024-10-12T21:46:23.000-04:00
gencat: Fix clippy::needless_range_loop
diff --git a/i18n/gencat.rs b/i18n/gencat.rs
@@ -553,6 +553,7 @@ impl MessageCatalog {
     }
 
     /// Read the **GNU based** binary catalog file and build [MessageCatalog]
+    #[allow(clippy::needless_range_loop)]
     pub fn read_catfile<T: Read>(
         mut input: T,
     ) -> Result<MessageCatalog, Box<dyn std::error::Error>> {
@@ -590,7 +591,7 @@ impl MessageCatalog {
             ptr += 4;
         }
 
-        // note: probably compare be_array and le_array as they should be the same
+        // TODO: probably compare be_array and le_array as they should be the same
 
         let string_pool = &buf[ptr..];
 

Original file line number	Diff line number	Diff line change
`@@ -553,6 +553,7 @@ impl MessageCatalog {`
`553`	`553`	`}`
`554`	`554`
`555`	`555`	`/// Read the GNU based binary catalog file and build [MessageCatalog]`
	`556`	`+ #[allow(clippy::needless_range_loop)]`
`556`	`557`	`pub fn read_catfile<T: Read>(`
`557`	`558`	`mut input: T,`
`558`	`559`	`) -> Result<MessageCatalog, Box<dyn std::error::Error>> {`
`@@ -590,7 +591,7 @@ impl MessageCatalog {`
`590`	`591`	`ptr += 4;`
`591`	`592`	`}`
`592`	`593`
`593`		`- // note: probably compare be_array and le_array as they should be the same`
	`594`	`+ // TODO: probably compare be_array and le_array as they should be the same`
`594`	`595`
`595`	`596`	`let string_pool = &buf[ptr..];`
`596`	`597`