Skip to content

Commit 670de1b

Browse files
committed
tests: introduce a shortcut type AddrSpace
Avoid constant repetition of "GuestMemoryMmap::<()>". Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
1 parent e3ed61a commit 670de1b

File tree

1 file changed

+21
-23
lines changed

1 file changed

+21
-23
lines changed

crates/virtio-queue/src/lib.rs

Lines changed: 21 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1036,6 +1036,8 @@ mod tests {
10361036

10371037
use vm_memory::{GuestAddress, GuestMemoryMmap};
10381038

1039+
type AddrSpace = GuestMemoryMmap<()>;
1040+
10391041
#[test]
10401042
pub fn test_offset() {
10411043
assert_eq!(offset_of!(Descriptor, addr), 0);
@@ -1046,21 +1048,19 @@ mod tests {
10461048

10471049
#[test]
10481050
fn test_checked_new_descriptor_chain() {
1049-
let m = &GuestMemoryMmap::<()>::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
1051+
let m = &AddrSpace::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
10501052
let vq = MockSplitQueue::new(m, 16);
10511053

10521054
assert!(vq.end().0 < 0x1000);
10531055

10541056
// index >= queue_size
1055-
assert!(
1056-
DescriptorChain::<&GuestMemoryMmap>::new(m, vq.start(), 16, 16)
1057-
.next()
1058-
.is_none()
1059-
);
1057+
assert!(DescriptorChain::<&AddrSpace>::new(m, vq.start(), 16, 16)
1058+
.next()
1059+
.is_none());
10601060

10611061
// desc_table address is way off
10621062
assert!(
1063-
DescriptorChain::<&GuestMemoryMmap>::new(m, GuestAddress(0x00ff_ffff_ffff), 16, 0)
1063+
DescriptorChain::<&AddrSpace>::new(m, GuestAddress(0x00ff_ffff_ffff), 16, 0)
10641064
.next()
10651065
.is_none()
10661066
);
@@ -1071,7 +1071,7 @@ mod tests {
10711071
let desc = Descriptor::new(0x1000, 0x1000, VIRTQ_DESC_F_NEXT, 16);
10721072
vq.desc_table().store(0, desc);
10731073

1074-
let mut c = DescriptorChain::<&GuestMemoryMmap>::new(m, vq.start(), 16, 0);
1074+
let mut c = DescriptorChain::<&AddrSpace>::new(m, vq.start(), 16, 0);
10751075
c.next().unwrap();
10761076
assert!(c.next().is_none());
10771077
}
@@ -1084,7 +1084,7 @@ mod tests {
10841084
let desc = Descriptor::new(0x2000, 0x1000, 0, 0);
10851085
vq.desc_table().store(1, desc);
10861086

1087-
let mut c = DescriptorChain::<&GuestMemoryMmap>::new(m, vq.start(), 16, 0);
1087+
let mut c = DescriptorChain::<&AddrSpace>::new(m, vq.start(), 16, 0);
10881088

10891089
assert_eq!(
10901090
c.memory() as *const GuestMemoryMmap,
@@ -1108,7 +1108,7 @@ mod tests {
11081108

11091109
#[test]
11101110
fn test_new_from_indirect_descriptor() {
1111-
let m = &GuestMemoryMmap::<()>::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
1111+
let m = &AddrSpace::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
11121112
let vq = MockSplitQueue::new(m, 16);
11131113
let dtable = vq.desc_table();
11141114

@@ -1120,7 +1120,7 @@ mod tests {
11201120
let desc = Descriptor::new(0x3000, 0x1000, 0, 0);
11211121
dtable.store(2, desc);
11221122

1123-
let mut c: DescriptorChain<&GuestMemoryMmap> = DescriptorChain::new(m, vq.start(), 16, 0);
1123+
let mut c: DescriptorChain<&AddrSpace> = DescriptorChain::new(m, vq.start(), 16, 0);
11241124

11251125
// The chain logic hasn't parsed the indirect descriptor yet.
11261126
assert!(!c.is_indirect);
@@ -1156,37 +1156,35 @@ mod tests {
11561156
#[test]
11571157
fn test_indirect_descriptor_err() {
11581158
{
1159-
let m = &GuestMemoryMmap::<()>::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
1159+
let m = &AddrSpace::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
11601160
let vq = MockSplitQueue::new(m, 16);
11611161

11621162
// create a chain with a descriptor pointing to an indirect table
11631163
let desc = Descriptor::new(0x1001, 0x1000, VIRTQ_DESC_F_INDIRECT, 0);
11641164
vq.desc_table().store(0, desc);
11651165

1166-
let mut c: DescriptorChain<&GuestMemoryMmap> =
1167-
DescriptorChain::new(m, vq.start(), 16, 0);
1166+
let mut c: DescriptorChain<&AddrSpace> = DescriptorChain::new(m, vq.start(), 16, 0);
11681167

11691168
assert!(c.next().is_none());
11701169
}
11711170

11721171
{
1173-
let m = &GuestMemoryMmap::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
1172+
let m = &AddrSpace::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
11741173
let vq = MockSplitQueue::new(m, 16);
11751174

11761175
// create a chain with a descriptor pointing to an indirect table
11771176
let desc = Descriptor::new(0x1000, 0x1001, VIRTQ_DESC_F_INDIRECT, 0);
11781177
vq.desc_table().store(0, desc);
11791178

1180-
let mut c: DescriptorChain<&GuestMemoryMmap> =
1181-
DescriptorChain::new(m, vq.start(), 16, 0);
1179+
let mut c: DescriptorChain<&AddrSpace> = DescriptorChain::new(m, vq.start(), 16, 0);
11821180

11831181
assert!(c.next().is_none());
11841182
}
11851183
}
11861184

11871185
#[test]
11881186
fn test_queue_and_iterator() {
1189-
let m = &GuestMemoryMmap::<()>::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
1187+
let m = &AddrSpace::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
11901188
let vq = MockSplitQueue::new(m, 16);
11911189

11921190
let mut q: Queue<_> = vq.as_queue(m);
@@ -1298,7 +1296,7 @@ mod tests {
12981296

12991297
#[test]
13001298
fn test_descriptor_and_iterator() {
1301-
let m = &GuestMemoryMmap::<()>::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
1299+
let m = &AddrSpace::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
13021300
let vq = MockSplitQueue::new(m, 16);
13031301

13041302
let mut q: Queue<_> = vq.as_queue(m);
@@ -1360,7 +1358,7 @@ mod tests {
13601358

13611359
#[test]
13621360
fn test_add_used() {
1363-
let m = &GuestMemoryMmap::<()>::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
1361+
let m = &AddrSpace::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
13641362
let vq = MockSplitQueue::new(m, 16);
13651363

13661364
let mut q: Queue<_> = vq.as_queue(m);
@@ -1397,7 +1395,7 @@ mod tests {
13971395

13981396
#[test]
13991397
fn test_reset_queue() {
1400-
let m = &GuestMemoryMmap::<()>::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
1398+
let m = &AddrSpace::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
14011399
let vq = MockSplitQueue::new(m, 16);
14021400

14031401
let mut q: Queue<_> = vq.as_queue(m);
@@ -1410,7 +1408,7 @@ mod tests {
14101408

14111409
#[test]
14121410
fn test_needs_notification() {
1413-
let m = &GuestMemoryMmap::<()>::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
1411+
let m = &AddrSpace::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
14141412
let qsize = 16;
14151413
let vq = MockSplitQueue::new(m, qsize);
14161414

@@ -1456,7 +1454,7 @@ mod tests {
14561454

14571455
#[test]
14581456
fn test_enable_disable_notification() {
1459-
let m = &GuestMemoryMmap::<()>::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
1457+
let m = &AddrSpace::from_ranges(&[(GuestAddress(0), 0x10000)]).unwrap();
14601458
let vq = MockSplitQueue::new(m, 16);
14611459

14621460
let mut q: Queue<_> = vq.as_queue(m);

0 commit comments

Comments
 (0)