Skip to content

Commit 903cabf

Browse files
committed
backend_req::tests: Extract test setup to a function
Extract creating a backend and a frontend from a socketpair to a utility function. Signed-off-by: Matej Hrica <mhrica@redhat.com>
1 parent 192551a commit 903cabf

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

vhost/src/vhost_user/backend_req.rs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -182,10 +182,16 @@ mod tests {
182182

183183
use super::*;
184184

185+
fn frontend_backend_pair() -> (Endpoint<VhostUserMsgHeader<BackendReq>>, Backend) {
186+
let (p1, p2) = UnixStream::pair().unwrap();
187+
let backend = Backend::from_stream(p1);
188+
let frontend = Endpoint::<VhostUserMsgHeader<BackendReq>>::from_stream(p2);
189+
(frontend, backend)
190+
}
191+
185192
#[test]
186193
fn test_backend_req_set_failed() {
187-
let (p1, _p2) = UnixStream::pair().unwrap();
188-
let backend = Backend::from_stream(p1);
194+
let (_, backend) = frontend_backend_pair();
189195

190196
assert!(backend.node().error.is_none());
191197
backend.set_failed(libc::EAGAIN);
@@ -194,8 +200,7 @@ mod tests {
194200

195201
#[test]
196202
fn test_backend_req_send_failure() {
197-
let (p1, _) = UnixStream::pair().unwrap();
198-
let backend = Backend::from_stream(p1);
203+
let (_, backend) = frontend_backend_pair();
199204

200205
backend.set_failed(libc::ECONNRESET);
201206
backend
@@ -209,9 +214,7 @@ mod tests {
209214

210215
#[test]
211216
fn test_backend_req_recv_negative() {
212-
let (p1, p2) = UnixStream::pair().unwrap();
213-
let backend = Backend::from_stream(p1);
214-
let mut frontend = Endpoint::<VhostUserMsgHeader<BackendReq>>::from_stream(p2);
217+
let (mut frontend, backend) = frontend_backend_pair();
215218

216219
let len = mem::size_of::<VhostUserSharedMsg>();
217220
let mut hdr = VhostUserMsgHeader::new(

0 commit comments

Comments
 (0)