Rollup merge of rust-lang#80750 - GuillaumeGomez:cleanup-to_string, r=lzutao

JohnTitor · web-flow · commit fd7f2443f1fe · 2021-01-08T02:06:14.000+09:00
Don't use to_string on Symbol in rustc_passes/check_attr.rs Improve code from rust-lang#80686. r? ``@lzutao``
diff --git a/compiler/rustc_passes/src/check_attr.rs b/compiler/rustc_passes/src/check_attr.rs
@@ -359,7 +359,7 @@ impl CheckAttrVisitor<'tcx> {
             return false;
         }
         let item_name = self.tcx.hir().name(hir_id);
-        if item_name.to_string() == doc_alias {
+        if &*item_name.as_str() == doc_alias {
             self.tcx
                 .sess
                 .struct_span_err(

Original file line number	Diff line number	Diff line change
`@@ -359,7 +359,7 @@ impl CheckAttrVisitor<'tcx> {`
`359`	`359`	`return false;`
`360`	`360`	`}`
`361`	`361`	`let item_name = self.tcx.hir().name(hir_id);`
`362`		`- if item_name.to_string() == doc_alias {`
	`362`	`+ if &*item_name.as_str() == doc_alias {`
`363`	`363`	`self.tcx`
`364`	`364`	`.sess`
`365`	`365`	`.struct_span_err(`