the operation is ineffective

Author: AntoineSebert

src/registers/control.rs

@@ -12,7 +12,7 @@ bitflags! {
     /// Configuration flags of the Cr0 register.
     pub struct Cr0Flags: u64 {
         /// Enables protected mode.
-        const PROTECTED_MODE_ENABLE = 1 << 0;
+        const PROTECTED_MODE_ENABLE = 1;
         /// Enables monitoring of the coprocessor, typical for x87 instructions.
         ///
         /// Controls together with the `TASK_SWITCHED` flag whether a `wait` or `fwait`
@@ -73,7 +73,7 @@ bitflags! {
     pub struct Cr4Flags: u64 {
         /// Enables hardware-supported performance enhancements for software running in
         /// virtual-8086 mode.
-        const VIRTUAL_8086_MODE_EXTENSIONS = 1 << 0;
+        const VIRTUAL_8086_MODE_EXTENSIONS = 1;
         /// Enables support for protected-mode virtual interrupts.
         const PROTECTED_MODE_VIRTUAL_INTERRUPTS = 1 << 1;
         /// When set, only privilege-level 0 can execute the RDTSC or RDTSCP instructions.

src/registers/model_specific.rs

@@ -85,7 +85,7 @@ bitflags! {
     /// Flags of the Extended Feature Enable Register.
     pub struct EferFlags: u64 {
         /// Enables the `syscall` and `sysret` instructions.
-        const SYSTEM_CALL_EXTENSIONS = 1 << 0;
+        const SYSTEM_CALL_EXTENSIONS = 1;
         /// Activates long mode, requires activating paging.
         const LONG_MODE_ENABLE = 1 << 8;
         /// Indicates that long mode is active.

src/registers/rflags.rs

@@ -58,7 +58,7 @@ bitflags! {
         const PARITY_FLAG = 1 << 2;
         /// Set by hardware if last arithmetic operation generated a carry out of the
         /// most-significant bit of the result.
-        const CARRY_FLAG = 1 << 0;
+        const CARRY_FLAG = 1;
     }
 }
 

src/structures/idt.rs

@@ -824,7 +824,7 @@ bitflags! {
     pub struct PageFaultErrorCode: u64 {
         /// If this flag is set, the page fault was caused by a page-protection violation,
         /// else the page fault was caused by a not-present page.
-        const PROTECTION_VIOLATION = 1 << 0;
+        const PROTECTION_VIOLATION = 1;
 
         /// If this flag is set, the memory access that caused the page fault was a write.
         /// Else the access that caused the page fault is a memory read. This bit does not

src/structures/paging/page_table.rs

@@ -114,7 +114,7 @@ bitflags! {
     /// Possible flags for a page table entry.
     pub struct PageTableFlags: u64 {
         /// Specifies whether the mapped frame or page table is loaded in memory.
-        const PRESENT =         1 << 0;
+        const PRESENT =         1;
         /// Controls whether writes to the mapped frames are allowed.
         ///
         /// If this bit is unset in a level 1 page table entry, the mapped frame is read-only.