FIX: Make internal iterator types and functions pub(crate)

These `pub` here actually predate the pub(crate) feature, and they
should just be `pub(crate)` or lower since they are unreachable outside
the crate.

Author: bluss

src/iterators/mod.rs

@@ -34,7 +34,7 @@ use std::slice::{self, Iter as SliceIter, IterMut as SliceIterMut};
 /// Base for iterators over all axes.
 ///
 /// Iterator element type is `*mut A`.
-pub struct Baseiter<A, D> {
+pub(crate) struct Baseiter<A, D> {
     ptr: *mut A,
     dim: D,
     strides: D,
@@ -321,7 +321,7 @@ pub struct Iter<'a, A, D> {
 }
 
 /// Counted read only iterator
-pub struct ElementsBase<'a, A, D> {
+pub(crate) struct ElementsBase<'a, A, D> {
     inner: Baseiter<A, D>,
     life: PhantomData<&'a A>,
 }
@@ -338,7 +338,7 @@ pub struct IterMut<'a, A, D> {
 /// An iterator over the elements of an array.
 ///
 /// Iterator element type is `&'a mut A`.
-pub struct ElementsBaseMut<'a, A, D> {
+pub(crate) struct ElementsBaseMut<'a, A, D> {
     inner: Baseiter<A, D>,
     life: PhantomData<&'a mut A>,
 }
@@ -767,7 +767,7 @@ where
 }
 
 #[derive(Debug)]
-pub struct AxisIterCore<A, D> {
+struct AxisIterCore<A, D> {
     /// Index along the axis of the value of `.next()`, relative to the start
     /// of the axis.
     index: Ix,
@@ -1445,8 +1445,7 @@ send_sync_read_write!(ElementsBaseMut);
 ///
 /// The iterator must produce exactly the number of elements it reported or
 /// diverge before reaching the end.
-#[allow(clippy::missing_safety_doc)] // not nameable downstream
-pub unsafe trait TrustedIterator {}
+pub(crate) unsafe trait TrustedIterator {}
 
 use crate::indexes::IndicesIterF;
 use crate::iter::IndicesIter;
@@ -1471,15 +1470,15 @@ unsafe impl<D> TrustedIterator for IndicesIterF<D> where D: Dimension {}
 unsafe impl<A, D> TrustedIterator for IntoIter<A, D> where D: Dimension {}
 
 /// Like Iterator::collect, but only for trusted length iterators
-pub fn to_vec<I>(iter: I) -> Vec<I::Item>
+pub(crate) fn to_vec<I>(iter: I) -> Vec<I::Item>
 where
     I: TrustedIterator + ExactSizeIterator,
 {
     to_vec_mapped(iter, |x| x)
 }
 
 /// Like Iterator::collect, but only for trusted length iterators
-pub fn to_vec_mapped<I, F, B>(iter: I, mut f: F) -> Vec<B>
+pub(crate) fn to_vec_mapped<I, F, B>(iter: I, mut f: F) -> Vec<B>
 where
     I: TrustedIterator + ExactSizeIterator,
     F: FnMut(I::Item) -> B,