Merge pull request #1420 from rust-ndarray/ci

Update CI settings: Use PR check instead of Merge Queue, and check rustdoc

Author: bluss

.github/workflows/ci.yaml

@@ -1,6 +1,9 @@
 on:
   pull_request:
   merge_group:
+  push:
+    branches:
+      - master
 
 name: Continuous integration
 
@@ -86,7 +89,7 @@ jobs:
       - run: ./scripts/all-tests.sh "$FEATURES" ${{ matrix.rust }}
 
   cross_test:
-    if: ${{ github.event_name == 'merge_group' }}
+    #if: ${{ github.event_name == 'merge_group' }}
     runs-on: ubuntu-latest
     strategy:
       matrix:
@@ -110,7 +113,7 @@ jobs:
       - run: ./scripts/cross-tests.sh "docs" ${{ matrix.rust }} ${{ matrix.target }}
 
   cargo-careful:
-    if: ${{ github.event_name == 'merge_group' }}
+    #if: ${{ github.event_name == 'merge_group' }}
     runs-on: ubuntu-latest
     name: cargo-careful
     steps:
@@ -124,19 +127,21 @@ jobs:
       - run: cargo careful test -Zcareful-sanitizer --features="$FEATURES"
 
   docs:
-    if: ${{ github.event_name == 'merge_group' }}
+    #if: ${{ github.event_name == 'merge_group' }}
     runs-on: ubuntu-latest
     strategy:
       matrix:
         rust:
           - stable
     name: docs/${{ matrix.rust }}
+    env:
+      RUSTDOCFLAGS: "-Dwarnings"
     steps:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@master
         with:
           toolchain: ${{ matrix.rust }}
-      - run: cargo doc
+      - run: cargo doc --no-deps --all-features
 
   conclusion:
     needs:

crates/blas-tests/Cargo.toml

@@ -7,6 +7,8 @@ edition = "2018"
 
 [lib]
 test = false
+doc = false
+doctest = false
 
 [dependencies]
 ndarray = { workspace = true, features = ["approx"] }

crates/numeric-tests/Cargo.toml

@@ -7,6 +7,8 @@ edition = "2018"
 
 [lib]
 test = false
+doc = false
+doctest = false
 
 [dependencies]
 ndarray = { workspace = true, features = ["approx"] }

crates/serialization-tests/Cargo.toml

@@ -7,6 +7,8 @@ edition = "2018"
 
 [lib]
 test = false
+doc = false
+doctest = false
 
 [dependencies]
 ndarray = { workspace = true, features = ["serde"] }

src/dimension/broadcast.rs

@@ -41,8 +41,8 @@ pub trait DimMax<Other: Dimension>
 }
 
 /// Dimensions of the same type remain unchanged when co_broadcast.
-/// So you can directly use D as the resulting type.
-/// (Instead of <D as DimMax<D>>::BroadcastOutput)
+/// So you can directly use `D` as the resulting type.
+/// (Instead of `<D as DimMax<D>>::BroadcastOutput`)
 impl<D: Dimension> DimMax<D> for D
 {
     type Output = D;

src/doc/crate_feature_flags.rs

@@ -30,3 +30,6 @@
 //!   - Enable the ``threading`` feature in the matrixmultiply package
 //!
 //! [`parallel`]: crate::parallel
+
+#[cfg(doc)]
+use crate::parallel::par_azip;

src/doc/ndarray_for_numpy_users/mod.rs

@@ -654,7 +654,7 @@
 //! convert `f32` array to `i32` array with ["saturating" conversion][sat_conv]; care needed because it can be a lossy conversion or result in non-finite values! See [the reference for information][as_typecast].
 //!
 //! </td></tr>
-//! <table>
+//! </table>
 //!
 //! [as_conv]: https://doc.rust-lang.org/rust-by-example/types/cast.html
 //! [sat_conv]: https://blog.rust-lang.org/2020/07/16/Rust-1.45.0.html#fixing-unsoundness-in-casts
@@ -677,6 +677,8 @@
 //! [.column()]: ArrayBase::column
 //! [.column_mut()]: ArrayBase::column_mut
 //! [concatenate()]: crate::concatenate()
+//! [concatenate!]: crate::concatenate!
+//! [stack!]: crate::stack!
 //! [::default()]: ArrayBase::default
 //! [.diag()]: ArrayBase::diag
 //! [.dim()]: ArrayBase::dim

src/doc/ndarray_for_numpy_users/rk_step.rs

@@ -169,6 +169,7 @@
 //! ```
 //!
 //! [`.scaled_add()`]: crate::ArrayBase::scaled_add
+//! [`azip!()`]: crate::azip!
 //!
 //! ### SciPy license
 //!

src/slice.rs

@@ -7,7 +7,10 @@
 // except according to those terms.
 use crate::dimension::slices_intersect;
 use crate::error::{ErrorKind, ShapeError};
+#[cfg(doc)]
+use crate::s;
 use crate::{ArrayViewMut, DimAdd, Dimension, Ix0, Ix1, Ix2, Ix3, Ix4, Ix5, Ix6, IxDyn};
+
 #[cfg(not(feature = "std"))]
 use alloc::vec::Vec;
 use std::convert::TryFrom;