Merge pull request #242 from rust-ndarray/lax-submod-private

Remove ndarray_linalg::lapack alias, make lax submodule private

Author: termoshtt

lax/src/lib.rs

@@ -68,21 +68,22 @@ extern crate openblas_src as _src;
 #[cfg(any(feature = "netlib-system", feature = "netlib-static"))]
 extern crate netlib_src as _src;
 
-pub mod cholesky;
-pub mod eig;
-pub mod eigh;
 pub mod error;
 pub mod layout;
-pub mod least_squares;
-pub mod opnorm;
-pub mod qr;
-pub mod rcond;
-pub mod solve;
-pub mod solveh;
-pub mod svd;
-pub mod svddc;
-pub mod triangular;
-pub mod tridiagonal;
+
+mod cholesky;
+mod eig;
+mod eigh;
+mod least_squares;
+mod opnorm;
+mod qr;
+mod rcond;
+mod solve;
+mod solveh;
+mod svd;
+mod svddc;
+mod triangular;
+mod tridiagonal;
 
 pub use self::cholesky::*;
 pub use self::eig::*;
@@ -159,7 +160,7 @@ pub enum NormType {
 }
 
 impl NormType {
-    pub(crate) fn transpose(self) -> Self {
+    pub fn transpose(self) -> Self {
         match self {
             NormType::One => NormType::Infinity,
             NormType::Infinity => NormType::One,

lax/src/opnorm.rs

@@ -1,11 +1,10 @@
 //! Operator norms of matrices
 
+use super::NormType;
 use crate::layout::MatrixLayout;
 use cauchy::*;
 use num_traits::Zero;
 
-pub use super::NormType;
-
 pub trait OperatorNorm_: Scalar {
     fn opnorm(t: NormType, l: MatrixLayout, a: &[Self]) -> Self::Real;
 }

ndarray-linalg/src/cholesky.rs

@@ -52,7 +52,7 @@ use crate::layout::*;
 use crate::triangular::IntoTriangular;
 use crate::types::*;
 
-pub use crate::lapack::UPLO;
+pub use lax::UPLO;
 
 /// Cholesky decomposition of Hermitian (or real symmetric) positive definite matrix
 pub struct CholeskyFactorized<S: Data> {

ndarray-linalg/src/convert.rs

@@ -1,9 +1,9 @@
 //! utilities for convert array
 
+use lax::UPLO;
 use ndarray::*;
 
 use super::error::*;
-use super::lapack::UPLO;
 use super::layout::*;
 use super::types::*;
 

ndarray-linalg/src/error.rs

@@ -14,7 +14,7 @@ pub enum LinalgError {
 
     /// LAPACK subroutine returns non-zero code
     #[error(transparent)]
-    Lapack(#[from] lapack::error::Error),
+    Lapack(#[from] lax::error::Error),
 
     /// Strides of the array is not supported
     #[error("invalid stride: s0={}, s1={}", s0, s1)]

ndarray-linalg/src/layout.rs

@@ -3,7 +3,7 @@
 use super::error::*;
 use ndarray::*;
 
-pub use lapack::layout::MatrixLayout;
+pub use lax::layout::MatrixLayout;
 
 pub trait AllocatedArray {
     type Elem;

ndarray-linalg/src/least_squares.rs

@@ -60,10 +60,10 @@
 //! // `a` and `b` have been moved, no longer valid
 //! ```
 
+use lax::*;
 use ndarray::*;
 
 use crate::error::*;
-use crate::lapack::least_squares::*;
 use crate::layout::*;
 use crate::types::*;
 
@@ -253,7 +253,7 @@ where
 /// valid representation for `ArrayBase`.
 impl<E, D> LeastSquaresSvdInPlace<D, E, Ix1> for ArrayBase<D, Ix2>
 where
-    E: Scalar + Lapack + LeastSquaresSvdDivideConquer_,
+    E: Scalar + Lapack,
     D: DataMut<Elem = E>,
 {
     /// Solve a least squares problem of the form `Ax = rhs`

ndarray-linalg/src/lib.rs

@@ -47,7 +47,6 @@
 
 #[macro_use]
 extern crate ndarray;
-extern crate lax as lapack;
 
 pub mod assert;
 pub mod cholesky;

ndarray-linalg/src/lobpcg/eig.rs

@@ -1,5 +1,7 @@
 use super::lobpcg::{lobpcg, LobpcgResult, Order};
-use crate::{generate, Lapack, Scalar};
+use crate::{generate, Scalar};
+use lax::Lapack;
+
 ///! Implements truncated eigenvalue decomposition
 ///
 use ndarray::prelude::*;

ndarray-linalg/src/lobpcg/lobpcg.rs

@@ -4,7 +4,8 @@
 ///which can be used as a solver for large symmetric positive definite eigenproblems.
 use crate::error::{LinalgError, Result};
 use crate::{cholesky::*, close_l2, eigh::*, norm::*, triangular::*};
-use crate::{Lapack, Scalar};
+use cauchy::Scalar;
+use lax::Lapack;
 use ndarray::prelude::*;
 use ndarray::{Data, OwnedRepr, ScalarOperand};
 use num_traits::{Float, NumCast};
@@ -338,7 +339,7 @@ pub fn lobpcg<
         let result = p_ap
             .as_ref()
             .ok_or(LinalgError::Lapack(
-                lapack::error::Error::LapackComputationalFailure { return_code: 1 },
+                lax::error::Error::LapackComputationalFailure { return_code: 1 },
             ))
             .and_then(|(active_p, active_ap)| {
                 let xap = x.t().dot(active_ap);