Explicit declaration of Float::exp and Float::abs

Author: termoshtt

ndarray-linalg/src/cholesky.rs

@@ -102,14 +102,14 @@ where
     type Output = <A as Scalar>::Real;
 
     fn detc(&self) -> Self::Output {
-        self.ln_detc().exp()
+        Float::exp(self.ln_detc())
     }
 
     fn ln_detc(&self) -> Self::Output {
         self.factor
             .diag()
             .iter()
-            .map(|elem| elem.square().ln())
+            .map(|elem| Float::ln(elem.square()))
             .sum::<Self::Output>()
     }
 }
@@ -443,7 +443,7 @@ where
     type Output = Result<<A as Scalar>::Real>;
 
     fn detc(&self) -> Self::Output {
-        Ok(self.ln_detc()?.exp())
+        Ok(Float::exp(self.ln_detc()?))
     }
 
     fn ln_detc(&self) -> Self::Output {
@@ -459,7 +459,7 @@ where
     type Output = Result<<A as Scalar>::Real>;
 
     fn detc_into(self) -> Self::Output {
-        Ok(self.ln_detc_into()?.exp())
+        Ok(Float::exp(self.ln_detc_into()?))
     }
 
     fn ln_detc_into(self) -> Self::Output {

ndarray-linalg/src/solve.rs

@@ -362,7 +362,7 @@ pub trait Determinant<A: Scalar> {
     /// Computes the determinant of the matrix.
     fn det(&self) -> Result<A> {
         let (sign, ln_det) = self.sln_det()?;
-        Ok(sign * A::from_real(ln_det.exp()))
+        Ok(sign * A::from_real(Float::exp(ln_det)))
     }
 
     /// Computes the `(sign, natural_log)` of the determinant of the matrix.
@@ -387,7 +387,7 @@ pub trait DeterminantInto<A: Scalar>: Sized {
     /// Computes the determinant of the matrix.
     fn det_into(self) -> Result<A> {
         let (sign, ln_det) = self.sln_det_into()?;
-        Ok(sign * A::from_real(ln_det.exp()))
+        Ok(sign * A::from_real(Float::exp(ln_det)))
     }
 
     /// Computes the `(sign, natural_log)` of the determinant of the matrix.
@@ -430,7 +430,7 @@ where
             let abs_elem: A::Real = elem.abs();
             (
                 upper_sign * elem / A::from_real(abs_elem),
-                ln_det + abs_elem.ln(),
+                ln_det + Float::ln(abs_elem),
             )
         },
     );

ndarray-linalg/src/solveh.rs

@@ -321,7 +321,7 @@ where
             let elem = unsafe { a.uget((k, k)) }.re();
             debug_assert_eq!(elem.im(), Zero::zero());
             sign *= elem.signum();
-            ln_det += elem.abs().ln();
+            ln_det += Float::ln(Float::abs(elem));
         } else {
             // 2x2 block at k..k+2.
 
@@ -348,7 +348,7 @@ where
             // Determinant of 2x2 block.
             let block_det = upper_diag * lower_diag - off_diag.square();
             sign *= block_det.signum();
-            ln_det += block_det.abs().ln();
+            ln_det += Float::ln(Float::abs(block_det));
 
             // Skip the k+1 ipiv value.
             ipiv_enum.next();
@@ -366,7 +366,7 @@ where
     /// symmetric) matrix.
     pub fn deth(&self) -> A::Real {
         let (sign, ln_det) = self.sln_deth();
-        sign * ln_det.exp()
+        sign * Float::exp(ln_det)
     }
 
     /// Computes the `(sign, natural_log)` of the determinant of the factorized
@@ -390,7 +390,7 @@ where
     /// symmetric) matrix.
     pub fn deth_into(self) -> A::Real {
         let (sign, ln_det) = self.sln_deth_into();
-        sign * ln_det.exp()
+        sign * Float::exp(ln_det)
     }
 
     /// Computes the `(sign, natural_log)` of the determinant of the factorized
@@ -420,7 +420,7 @@ where
 
     fn deth(&self) -> Result<A::Real> {
         let (sign, ln_det) = self.sln_deth()?;
-        Ok(sign * ln_det.exp())
+        Ok(sign * Float::exp(ln_det))
     }
 
     fn sln_deth(&self) -> Result<(A::Real, A::Real)> {
@@ -445,7 +445,7 @@ where
 
     fn deth_into(self) -> Result<A::Real> {
         let (sign, ln_det) = self.sln_deth_into()?;
-        Ok(sign * ln_det.exp())
+        Ok(sign * Float::exp(ln_det))
     }
 
     fn sln_deth_into(self) -> Result<(A::Real, A::Real)> {

ndarray-linalg/tests/det.rs

@@ -110,7 +110,7 @@ fn det() {
     {
         let det = det_naive(&a);
         let sign = det.div_real(det.abs());
-        let ln_det = det.abs().ln();
+        let ln_det = Float::ln(det.abs());
         assert_rclose!(a.factorize().unwrap().det().unwrap(), det, rtol);
         {
             let result = a.factorize().unwrap().sln_det().unwrap();

ndarray-linalg/tests/opnorm.rs

@@ -1,6 +1,5 @@
 use ndarray::*;
 use ndarray_linalg::*;
-use num_traits::Float;
 
 fn test(a: Array2<f64>, one: f64, inf: f64, fro: f64) {
     println!("ONE = {:?}", a.opnorm_one());

ndarray-linalg/tests/vector.rs

@@ -1,6 +1,5 @@
 use ndarray::*;
 use ndarray_linalg::*;
-use num_traits::Float;
 
 #[test]
 fn vector_norm() {