@@ -51,7 +51,7 @@ impl<A: Float + PartialOrd + DivAssign<A> + 'static> TruncatedSvdResult<A> {
5151 }
5252
5353 /// Returns singular values, left-singular vectors and right-singular vectors
54- pub fn values_vecs ( & self ) -> ( Array2 < A > , Array1 < A > , Array2 < A > ) {
54+ pub fn values_vectors ( & self ) -> ( Array2 < A > , Array1 < A > , Array2 < A > ) {
5555 let ( values, indices) = self . singular_values_with_indices ( ) ;
5656
5757 // branch n > m (for A is [n x m])
@@ -115,8 +115,8 @@ impl<A: Scalar + Lapack + PartialOrd + Default> TruncatedSvd<A> {
115115
116116 }
117117
118- // calculate the eigenvalues once
119- pub fn once ( self , num : usize ) -> Result < TruncatedSvdResult < A > > {
118+ // calculate the eigenvalue decomposition
119+ pub fn decompose ( self , num : usize ) -> Result < TruncatedSvdResult < A > > {
120120 let ( n, m) = ( self . problem . nrows ( ) , self . problem . ncols ( ) ) ;
121121
122122 let x = Array2 :: random ( ( usize:: min ( n, m) , num) , Uniform :: new ( 0.0 , 1.0 ) )
@@ -164,7 +164,7 @@ mod tests {
164164 let res = TruncatedSvd :: new ( a, Order :: Largest )
165165 . precision ( 1e-5 )
166166 . maxiter ( 10 )
167- . once ( 2 )
167+ . decompose ( 2 )
168168 . unwrap ( ) ;
169169
170170 let ( _, sigma, _) = res. values_vecs ( ) ;
@@ -179,10 +179,10 @@ mod tests {
179179 let res = TruncatedSvd :: new ( a. clone ( ) , Order :: Largest )
180180 . precision ( 1e-5 )
181181 . maxiter ( 10 )
182- . once ( 10 )
182+ . decompose ( 10 )
183183 . unwrap ( ) ;
184184
185- let ( u, sigma, v_t) = res. values_vecs ( ) ;
185+ let ( u, sigma, v_t) = res. values_vectors ( ) ;
186186 let reconstructed = u. dot ( & Array2 :: from_diag ( & sigma) . dot ( & v_t) ) ;
187187
188188 close_l2 ( & a, & reconstructed, 1e-5 ) ;
0 commit comments