Replace orthogonalize into coeff

Author: termoshtt

src/krylov/mgs.rs

@@ -39,19 +39,12 @@ impl<A: Scalar> MGS<A> {
             q: Vec::new(),
         }
     }
-}
-
-impl<A: Scalar + Lapack> Orthogonalizer for MGS<A> {
-    type Elem = A;
-
-    fn dim(&self) -> usize {
-        self.dimension
-    }
-
-    fn len(&self) -> usize {
-        self.q.len()
-    }
 
+    /// Orthogonalize given vector against to the current basis
+    ///
+    /// - Returned array is coefficients and residual norm
+    /// - `a` will contain the residual vector
+    ///
     fn orthogonalize<S>(&self, a: &mut ArrayBase<S, Ix1>) -> Array1<A>
     where
         A: Lapack,
@@ -69,6 +62,27 @@ impl<A: Scalar + Lapack> Orthogonalizer for MGS<A> {
         coef[self.len()] = A::from_real(nrm);
         coef
     }
+}
+
+impl<A: Scalar + Lapack> Orthogonalizer for MGS<A> {
+    type Elem = A;
+
+    fn dim(&self) -> usize {
+        self.dimension
+    }
+
+    fn len(&self) -> usize {
+        self.q.len()
+    }
+
+    fn coeff<S>(&self, a: ArrayBase<S, Ix1>) -> Array1<A>
+    where
+        A: Lapack,
+        S: Data<Elem = A>,
+    {
+        let mut a = a.into_owned();
+        self.orthogonalize(&mut a)
+    }
 
     fn append<S>(&mut self, a: ArrayBase<S, Ix1>, rtol: A::Real) -> Result<Array1<A>, Array1<A>>
     where

src/krylov/mod.rs

@@ -40,15 +40,18 @@ pub trait Orthogonalizer {
         self.len() == 0
     }
 
-    /// Orthogonalize given vector using current basis
+    /// Calculate the coefficient to the given basis and residual norm
+    ///
+    /// - The length of the returned array must be `self.len() + 1`
+    /// - Last component is the residual norm
     ///
     /// Panic
     /// -------
     /// - if the size of the input array mismatches to the dimension
     ///
-    fn orthogonalize<S>(&self, a: &mut ArrayBase<S, Ix1>) -> Array1<Self::Elem>
+    fn coeff<S>(&self, a: ArrayBase<S, Ix1>) -> Array1<Self::Elem>
     where
-        S: DataMut<Elem = Self::Elem>;
+        S: Data<Elem = Self::Elem>;
 
     /// Add new vector if the residual is larger than relative tolerance
     ///