Merge pull request #1992 from Kobzol/unique-zulip-id

Ensure that Zulip user IDs are unique

Author: Mark-Simulacrum

people/jonathanpallant.toml

@@ -2,4 +2,4 @@ name = 'Jonathan Pallant'
 github = 'jonathanpallant'
 github-id = 18005923
 email = 'jonathan.pallant@ferrous-systems.com'
-zulip-id = 203633
+zulip-id = 734957

src/validate.rs

@@ -49,6 +49,7 @@ static CHECKS: &[Check<fn(&Data, &mut Vec<String>)>] = checks![
     validate_zulip_group_ids,
     validate_zulip_group_extra_people,
     validate_unique_zulip_streams,
+    validate_unique_zulip_user_ids,
     validate_zulip_stream_ids,
     validate_zulip_stream_extra_people,
     validate_repos,
@@ -720,6 +721,22 @@ fn validate_zulip_users(data: &Data, zulip: &ZulipApi, errors: &mut Vec<String>)
     })
 }
 
+/// Ensure that no two users have the same Zulip ID
+fn validate_unique_zulip_user_ids(data: &Data, errors: &mut Vec<String>) {
+    let mut zulip_ids = HashMap::new();
+    wrapper(data.people(), errors, |person, _| {
+        if let Some(zulip_id) = person.zulip_id() {
+            if let Some(previous) = zulip_ids.insert(zulip_id, person.github()) {
+                return Err(anyhow::anyhow!(
+                    "{previous} and {} have the same Zulip user ID: {zulip_id}",
+                    person.github()
+                ));
+            }
+        }
+        Ok(())
+    })
+}
+
 /// Ensure team members in Zulip groups have a Zulip id
 fn validate_zulip_group_ids(data: &Data, errors: &mut Vec<String>) {
     wrapper(data.teams(), errors, |team, errors| {