detect broken manifest furing fetch

Author: Skgland

src/prepare.rs

@@ -145,6 +145,7 @@ pub(crate) fn fetch_deps(
 fn run_command(cmd: Command) -> anyhow::Result<()> {
     let mut yanked_deps = false;
     let mut missing_deps = false;
+    let mut broken_deps = false;
 
     let mut process = |line: &str, _: &mut ProcessLinesActions| {
         if line.contains("failed to select a version for the requirement") {
@@ -153,6 +154,8 @@ fn run_command(cmd: Command) -> anyhow::Result<()> {
             || line.contains("no matching package named")
         {
             missing_deps = true;
+        } else if line.contains("failed to parse manifest at") {
+            broken_deps = true;
         }
     };
 
@@ -164,6 +167,9 @@ fn run_command(cmd: Command) -> anyhow::Result<()> {
         Err(CommandError::ExecutionFailed { status: _, stderr }) if missing_deps => {
             Err(PrepareError::MissingDependencies(stderr).into())
         }
+        Err(CommandError::ExecutionFailed { status: _, stderr }) if broken_deps => {
+            Err(PrepareError::BrokenDependencies(stderr).into())
+        }
         Err(err) => Err(err.into()),
     }
 }
@@ -373,6 +379,9 @@ pub enum PrepareError {
     /// rejecting it.
     #[error("invalid Cargo.toml syntax")]
     InvalidCargoTomlSyntax,
+    /// Something about the crates dependencies is invalid
+    #[error("broken dependencies: \n\n{0}")]
+    BrokenDependencies(String),
     /// Some of this crate's dependencies were yanked, preventing Crater from fetching them.
     #[error("the crate depends on yanked dependencies: \n\n{0}")]
     YankedDependencies(String),

tests/buildtest/crates/invalid-cargotoml-missing-registry-config/Cargo.lock

@@ -261,7 +261,7 @@ test_prepare_error_stderr!(
     "error: no matching package named `macro` found"
 );
 
-test_prepare_unknown_err!(
+test_prepare_error_stderr!(
     test_invalid_cargotoml_content_deps,
     "invalid-cargotoml-content-deps",
     BrokenDependencies,
@@ -303,10 +303,10 @@ test_prepare_unknown_err!(
     "error: cyclic package dependency: package"
 );
 
-test_prepare_unknown_err!(
+test_prepare_error_stderr!(
     test_invalid_cargotoml_missing_registry_config,
     "invalid-cargotoml-missing-registry-config",
-    MissingDependencies,
+    BrokenDependencies,
     "registry index was not found in any configuration: `will-be-removed`"
 );