applease clippy

Author: pietroalbini

src/cmd/sandbox.rs

@@ -31,7 +31,7 @@ impl SandboxImage {
         let mut image = SandboxImage { name: name.into() };
         info!("pulling image {} from Docker Hub", name);
         Command::new_workspaceless("docker")
-            .args(&["pull", &name])
+            .args(&["pull", name])
             .run()
             .map_err(|e| CommandError::SandboxImagePullFailed(Box::new(e)))?;
         if let Some(name_with_hash) = image.get_name_with_hash() {

src/inside_docker.rs

@@ -65,7 +65,7 @@ pub(crate) fn probe_container_id(workspace: &Workspace) -> Result<Option<String>
         info!("probing container id {}", id);
 
         let res = Command::new(workspace, "docker")
-            .args(&["exec", &id, "cat", probe_path_str])
+            .args(&["exec", id, "cat", probe_path_str])
             .log_output(false)
             .log_command(false)
             .run_capture();

src/native/unix.rs

@@ -50,7 +50,7 @@ fn executable_mode_for(path: &Path) -> Result<u32, Error> {
 pub(crate) fn is_executable<P: AsRef<Path>>(path: P) -> Result<bool, Error> {
     let path = path.as_ref();
 
-    let expected_mode = executable_mode_for(&path)?;
+    let expected_mode = executable_mode_for(path)?;
     Ok(path.metadata()?.mode() & expected_mode == expected_mode)
 }
 
@@ -59,7 +59,7 @@ pub(crate) fn make_executable<P: AsRef<Path>>(path: P) -> Result<(), Error> {
 
     // Set the executable and readable bits on the file
     let mut perms = path.metadata()?.permissions();
-    let new_mode = perms.mode() | executable_mode_for(&path)?;
+    let new_mode = perms.mode() | executable_mode_for(path)?;
     perms.set_mode(new_mode);
 
     ::std::fs::set_permissions(path, perms)?;

src/prepare.rs

@@ -86,7 +86,7 @@ impl<'a> Prepare<'a> {
 
     fn tweak_toml(&self) -> Result<(), Error> {
         let path = self.source_dir.join("Cargo.toml");
-        let mut tweaker = TomlTweaker::new(&self.krate, &path, &self.patches)?;
+        let mut tweaker = TomlTweaker::new(self.krate, &path, &self.patches)?;
         tweaker.tweak();
         tweaker.save(&path)?;
         Ok(())

src/utils.rs

@@ -68,7 +68,7 @@ fn strip_verbatim_from_prefix(prefix: &PrefixComponent<'_>) -> Option<PathBuf> {
 }
 
 pub(crate) fn remove_file(path: &Path) -> std::io::Result<()> {
-    std::fs::remove_file(&path).map_err(|error| crate::utils::improve_remove_error(error, &path))
+    std::fs::remove_file(&path).map_err(|error| crate::utils::improve_remove_error(error, path))
 }
 
 pub(crate) fn remove_dir_all(path: &Path) -> std::io::Result<()> {

src/workspace.rs

@@ -232,7 +232,7 @@ impl Workspace {
 
         for path in &paths {
             if path.exists() {
-                crate::utils::remove_dir_all(&path)?;
+                crate::utils::remove_dir_all(path)?;
             }
         }