feat(install): add skip_std flag to allow skipping rust-std installation for custom targets
#4587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Nov 4, 2025
Contributor
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
So I'm not sure yet how/where the ToolchainSection::skip_std field makes it into the DistOptions?
cachebag
force-pushed
the
force-skip-std
branch
from
da619eb to
c5b3caa
Compare
cachebag
force-pushed
the
force-skip-std
branch
from
c5b3caa to
2d5fe7f
Compare
Contributor
Author
Yeah, sorry about that. I think it should be fine now, the flag flows through the chain where it should be applied as |
cachebag
commented
Nov 4, 2025
cachebag
force-pushed
the
force-skip-std
branch
from
753df2e to
f656d33
Compare
Contributor
|
(You'll need to rebase and squash before this can be merged.) |
cachebag
force-pushed
the
force-skip-std
branch
2 times, most recently
from
52b54a3 to
70d2e69
Compare
cachebag
force-pushed
the
force-skip-std
branch
from
70d2e69 to
0a784f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4442
Revision of #4585