notifications: log directly about rolling back changes

Author: djc

src/dist/component/transaction.rs

@@ -13,6 +13,7 @@ use std::fs::File;
 use std::path::{Path, PathBuf};
 
 use anyhow::{Context, Result, anyhow};
+use tracing::info;
 
 use crate::dist::prefix::InstallPrefix;
 use crate::dist::temp;
@@ -172,7 +173,7 @@ impl<'a> Transaction<'a> {
 impl Drop for Transaction<'_> {
     fn drop(&mut self) {
         if !self.committed {
-            (self.notify_handler)(Notification::RollingBack);
+            info!("rolling back changes");
             for item in self.changes.iter().rev() {
                 // ok_ntfy!(self.notify_handler,
                 //          Notification::NonFatalError,

src/notifications.rs

@@ -19,7 +19,6 @@ pub enum Notification<'a> {
     ChecksumValid(&'a str),
     FileAlreadyDownloaded,
     CachedFileChecksumFailed,
-    RollingBack,
     ExtensionNotInstalled(&'a str),
     NonFatalError(&'a anyhow::Error),
     MissingInstalledComponent(&'a str),
@@ -98,7 +97,6 @@ impl Notification<'_> {
             | RemovingComponent(_, _, _)
             | RemovingOldComponent(_, _, _)
             | ComponentAlreadyInstalled(_)
-            | RollingBack
             | DownloadingManifest(_)
             | SkippingNightlyMissingComponent(_, _, _)
             | RetryingDownload(_)
@@ -164,7 +162,6 @@ impl Display for Notification<'_> {
             ChecksumValid(_) => write!(f, "checksum passed"),
             FileAlreadyDownloaded => write!(f, "reusing previously downloaded file"),
             CachedFileChecksumFailed => write!(f, "bad checksum for cached download"),
-            RollingBack => write!(f, "rolling back changes"),
             ExtensionNotInstalled(c) => write!(f, "extension '{c}' was not installed"),
             NonFatalError(e) => write!(f, "{e}"),
             MissingInstalledComponent(c) => {