notifications: log directly when toolchain is up to date

Author: djc

src/install.rs

@@ -9,7 +9,6 @@ use crate::{
     config::Cfg,
     dist::{self, DistOptions, prefix::InstallPrefix},
     errors::RustupError,
-    notifications::Notification,
     toolchain::{CustomToolchainName, LocalToolchainName, Toolchain},
     utils,
 };
@@ -45,7 +44,6 @@ impl InstallMethod<'_> {
         let _ = rayon::ThreadPoolBuilder::new()
             .num_threads(self.cfg().process.io_thread_count()?)
             .build_global();
-        let nh = &self.cfg().notify_handler;
         match self {
             InstallMethod::Copy { .. }
             | InstallMethod::Link { .. }
@@ -61,7 +59,7 @@ impl InstallMethod<'_> {
 
         let status = match updated {
             false => {
-                nh(Notification::UpdateHashMatches);
+                debug!("toolchain is already up to date");
                 UpdateStatus::Unchanged
             }
             true => {

src/notifications.rs

@@ -28,7 +28,6 @@ pub(crate) enum Notification<'a> {
     SetDefaultBufferSize(usize),
     UninstallingToolchain(&'a ToolchainName),
     UninstalledToolchain(&'a ToolchainName),
-    UpdateHashMatches,
     UpgradingMetadata(MetadataVersion, MetadataVersion),
     MetadataUpgradeNotNeeded(MetadataVersion),
     ReadMetadataVersion(MetadataVersion),
@@ -52,9 +51,7 @@ impl Notification<'_> {
             | DownloadDataReceived(_, _)
             | DownloadFinished(_)
             | DownloadFailed(_) => NotificationLevel::Debug,
-            ReadMetadataVersion(_) | UpdateHashMatches => {
-                NotificationLevel::Debug
-            }
+            ReadMetadataVersion(_) => NotificationLevel::Debug,
             UninstallingToolchain(_)
             | UninstalledToolchain(_)
             | UpgradingMetadata(_, _)
@@ -89,7 +86,6 @@ impl Display for Notification<'_> {
             DownloadFailed(_) => write!(f, "download failed"),
             UninstallingToolchain(name) => write!(f, "uninstalling toolchain '{name}'"),
             UninstalledToolchain(name) => write!(f, "toolchain '{name}' uninstalled"),
-            UpdateHashMatches => write!(f, "toolchain is already up to date"),
             UpgradingMetadata(from_ver, to_ver) => write!(
                 f,
                 "upgrading metadata version from '{from_ver}' to '{to_ver}'"