notifications: log directly when installing toolchains

Author: djc

src/install.rs

@@ -52,8 +52,8 @@ impl InstallMethod<'_> {
             | InstallMethod::Dist(DistOptions {
                 old_date_version: None,
                 ..
-            }) => nh(Notification::InstallingToolchain(&self.dest_basename())),
-            _ => nh(Notification::UpdatingToolchain(&self.dest_basename())),
+            }) => debug!("installing toolchain {}", self.dest_basename()),
+            _ => debug!("updating existing install for '{}'", self.dest_basename()),
         }
 
         debug!("toolchain directory: {}", self.dest_path().display());

src/notifications.rs

@@ -26,8 +26,6 @@ pub(crate) enum Notification<'a> {
     /// member, but the notification callback is already narrowed to
     /// utils::notifications by the time tar unpacking is called.
     SetDefaultBufferSize(usize),
-    UpdatingToolchain(&'a str),
-    InstallingToolchain(&'a str),
     InstalledToolchain(&'a str),
     UninstallingToolchain(&'a ToolchainName),
     UninstalledToolchain(&'a ToolchainName),
@@ -55,11 +53,9 @@ impl Notification<'_> {
             | DownloadDataReceived(_, _)
             | DownloadFinished(_)
             | DownloadFailed(_) => NotificationLevel::Debug,
-            InstallingToolchain(_)
-            | UpdatingToolchain(_)
-            | ReadMetadataVersion(_)
-            | InstalledToolchain(_)
-            | UpdateHashMatches => NotificationLevel::Debug,
+            ReadMetadataVersion(_) | InstalledToolchain(_) | UpdateHashMatches => {
+                NotificationLevel::Debug
+            }
             UninstallingToolchain(_)
             | UninstalledToolchain(_)
             | UpgradingMetadata(_, _)
@@ -92,8 +88,6 @@ impl Display for Notification<'_> {
             DownloadDataReceived(data, _) => write!(f, "received some data of size {}", data.len()),
             DownloadFinished(_) => write!(f, "download finished"),
             DownloadFailed(_) => write!(f, "download failed"),
-            UpdatingToolchain(name) => write!(f, "updating existing install for '{name}'"),
-            InstallingToolchain(name) => write!(f, "installing toolchain '{name}'"),
             InstalledToolchain(name) => write!(f, "toolchain '{name}' installed"),
             UninstallingToolchain(name) => write!(f, "uninstalling toolchain '{name}'"),
             UninstalledToolchain(name) => write!(f, "toolchain '{name}' uninstalled"),