Make needless_borrow clippy happy

Signed-off-by: hi-rustin <rustin.liu@gmail.com>

Author: 0xPoe

src/cli/rustup_mode.rs

@@ -1671,7 +1671,7 @@ fn output_completion_script(shell: Shell, command: CompletionCommand) -> Result<
         }
         CompletionCommand::Cargo => {
             if let Shell::Zsh = shell {
-                writeln!(&mut term2::stdout(), "#compdef cargo")?;
+                writeln!(term2::stdout(), "#compdef cargo")?;
             }
 
             let script = match shell {
@@ -1687,7 +1687,7 @@ fn output_completion_script(shell: Shell, command: CompletionCommand) -> Result<
             };
 
             writeln!(
-                &mut term2::stdout(),
+                term2::stdout(),
                 "if command -v rustc >/dev/null 2>&1; then\n\
                     \tsource \"$(rustc --print sysroot)\"{}\n\
                  fi",

src/diskio/immediate.rs

@@ -204,7 +204,7 @@ impl IncrementalFileWriter {
     fn write(&mut self, chunk: Vec<u8>) -> std::result::Result<bool, io::Error> {
         let mut state = self.state.lock().unwrap();
         if let Some(ref mut state) = *state {
-            if let Some(ref mut file) = (&mut self.file).as_mut() {
+            if let Some(ref mut file) = self.file.as_mut() {
                 // Length 0 vector is used for clean EOF signalling.
                 if chunk.is_empty() {
                     trace_scoped!("close", "name:": self.path_display);

src/utils/raw.rs

@@ -79,7 +79,7 @@ pub(crate) fn filter_file<F: FnMut(&str) -> bool>(
     for result in io::BufRead::lines(&mut reader) {
         let line = result?;
         if filter(&line) {
-            writeln!(&mut writer, "{}", &line)?;
+            writeln!(writer, "{}", &line)?;
         } else {
             removed += 1;
         }
@@ -97,7 +97,7 @@ pub fn append_file(dest: &Path, line: &str) -> io::Result<()> {
         .create(true)
         .open(dest)?;
 
-    writeln!(&mut dest_file, "{}", line)?;
+    writeln!(dest_file, "{}", line)?;
 
     dest_file.sync_data()?;
 

tests/dist_transactions.rs

@@ -27,7 +27,7 @@ fn add_file() {
     let mut tx = Transaction::new(prefix.clone(), &tmpcfg, &notify);
 
     let mut file = tx.add_file("c", PathBuf::from("foo/bar")).unwrap();
-    write!(&mut file, "test").unwrap();
+    write!(file, "test").unwrap();
 
     tx.commit();
     drop(file);
@@ -759,9 +759,9 @@ fn rollback_failure_keeps_going() {
     let notify = |_: Notification<'_>| ();
     let mut tx = Transaction::new(prefix.clone(), &tmpcfg, &notify);
 
-    write!(&mut tx.add_file("", PathBuf::from("foo")).unwrap(), "").unwrap();
-    write!(&mut tx.add_file("", PathBuf::from("bar")).unwrap(), "").unwrap();
-    write!(&mut tx.add_file("", PathBuf::from("baz")).unwrap(), "").unwrap();
+    write!(tx.add_file("", PathBuf::from("foo")).unwrap(), "").unwrap();
+    write!(tx.add_file("", PathBuf::from("bar")).unwrap(), "").unwrap();
+    write!(tx.add_file("", PathBuf::from("baz")).unwrap(), "").unwrap();
 
     fs::remove_file(prefix.path().join("bar")).unwrap();