style: Encourage using existing imports

This came up in #4520 as way to help automate review feedback

Author: epage

Cargo.toml

@@ -145,7 +145,8 @@ trycmd = "0.15.0"
 platforms = "3.4"
 
 [lints.rust]
-rust_2018_idioms = "deny"
+rust_2018_idioms = { level = "deny", priority = -1 }
+unused_qualifications = "warn"
 
 [lints.clippy]
 # `dbg!()` and `todo!()` clearly shouldn't make it to production:

src/cli/job.rs

@@ -85,7 +85,7 @@ mod imp {
                 job.inner,
                 JobObjectExtendedLimitInformation,
                 &mut info as *mut _ as *const std::ffi::c_void,
-                mem::size_of_val(&info) as u32,
+                size_of_val(&info) as u32,
             );
             if r == 0 {
                 return None;
@@ -115,7 +115,7 @@ mod imp {
                     self.job.inner,
                     JobObjectExtendedLimitInformation,
                     &mut info as *mut _ as *const std::ffi::c_void,
-                    mem::size_of_val(&info) as u32,
+                    size_of_val(&info) as u32,
                 );
                 if r == 0 {
                     info!("failed to configure job object to defaults: {}", last_err());

src/cli/log.rs

@@ -19,10 +19,7 @@ use crate::{process::Process, utils::notify::NotificationLevel};
 
 pub fn tracing_subscriber(
     process: &Process,
-) -> (
-    impl tracing::Subscriber + use<>,
-    reload::Handle<EnvFilter, Registry>,
-) {
+) -> (impl Subscriber + use<>, reload::Handle<EnvFilter, Registry>) {
     #[cfg(feature = "otel")]
     let telemetry = telemetry(process);
     let (console_logger, console_filter) = console_logger(process);