Merge pull request #2460 from rbtcollins/clippy

More clippy coverage recommendations

Author: rbtcollins

CONTRIBUTING.md

@@ -3,7 +3,7 @@
 1. Fork it!
 2. Create your feature branch: `git checkout -b my-new-feature`
 3. Test it: `cargo test`
-4. Lint it: `cargo +nightly clippy --all-targets -- -D warnings`
+4. Lint it: `cargo +nightly clippy --all --all-targets -- -D warnings`
 5. Commit your changes: `git commit -am 'Add some feature'`
 6. Push to the branch: `git push origin my-new-feature`
 7. Submit a pull request :D
@@ -69,9 +69,12 @@ clippy is a moving target that can make it hard to merge for little benefit.
 
 We do ask that contributors keep the clippy status clean themselves.
 
-Minimally, run `cargo +nightly clippy --all-targets -- -D warnings` before
+Minimally, run `cargo +nightly clippy --all --all-targets -- -D warnings` before
 submitting code.
 
+If possible, adding `--all-features` to the command is useful, but will require
+additional dependencies like `libcurl-dev`.
+
 Regular contributors or contributors to particularly OS-specific code should
 also make sure that their clippy checking is done on at least Linux and Windows,
 as OS-conditional code is a common source of unused imports and other small

download/tests/download-curl-resume.rs

@@ -58,7 +58,7 @@ fn callback_gets_all_data_as_if_the_download_happened_all_at_once() {
                 }
                 Event::DownloadDataReceived(data) => {
                     for b in data.iter() {
-                        received_in_callback.lock().unwrap().push(b.clone());
+                        received_in_callback.lock().unwrap().push(*b);
                     }
                 }
             }

download/tests/download-reqwest-resume.rs

@@ -58,7 +58,7 @@ fn callback_gets_all_data_as_if_the_download_happened_all_at_once() {
                 }
                 Event::DownloadDataReceived(data) => {
                     for b in data.iter() {
-                        received_in_callback.lock().unwrap().push(b.clone());
+                        received_in_callback.lock().unwrap().push(*b);
                     }
                 }
             }

tests/cli-paths.rs

@@ -99,7 +99,7 @@ export PATH="$HOME/apple/bin"
             expect_ok(config, &INIT_NONE);
 
             for (before, after) in rcs_before.zip(rcs.iter().map(|rc| rc.exists())) {
-                assert!(before == false);
+                assert!(!before);
                 assert_eq!(before, after);
             }
         });