Update code to use home::env as home as suggested

Author: LucioFranco

src/currentprocess.rs

@@ -9,6 +9,7 @@ use std::path::{Path, PathBuf};
 use std::sync::Once;
 use std::sync::{Arc, Mutex};
 
+use home::env as home;
 use rand::{thread_rng, Rng};
 
 pub(crate) mod argsource;
@@ -55,15 +56,15 @@ use varsource::*;
 /// The real trait is CurrentProcess; HomeProcess is a single trait because
 /// Box<T> only allows autotraits to be added to it; so we use a subtrait to add
 /// home::Env in.
-pub trait HomeProcess: CurrentProcess + home::env::Env {
+pub trait HomeProcess: CurrentProcess + home::Env {
     fn clone_boxed(&self) -> Box<dyn HomeProcess>;
 }
 
 // Machinery for Cloning boxes
 
 impl<T> HomeProcess for T
 where
-    T: 'static + CurrentProcess + home::env::Env + Clone,
+    T: 'static + CurrentProcess + home::Env + Clone,
 {
     fn clone_boxed(&self) -> Box<dyn HomeProcess + 'static> {
         Box::new(T::clone(self))

src/currentprocess/homethunk.rs

@@ -4,25 +4,27 @@ use std::io;
 use std::ops::Deref;
 use std::path::PathBuf;
 
+use home::env as home;
+
 use super::CurrentDirSource;
 use super::HomeProcess;
 use super::OSProcess;
 use super::TestProcess;
 use super::VarSource;
 
-impl home::env::Env for Box<dyn HomeProcess + 'static> {
+impl home::Env for Box<dyn HomeProcess + 'static> {
     fn home_dir(&self) -> Option<PathBuf> {
         (**self).home_dir()
     }
     fn current_dir(&self) -> Result<PathBuf, io::Error> {
-        home::env::Env::current_dir(&(**self))
+        home::Env::current_dir(&(**self))
     }
     fn var_os(&self, key: &str) -> Option<OsString> {
-        home::env::Env::var_os(&(**self), key)
+        home::Env::var_os(&(**self), key)
     }
 }
 
-impl home::env::Env for TestProcess {
+impl home::Env for TestProcess {
     fn home_dir(&self) -> Option<PathBuf> {
         self.var("HOME").ok().map(|v| v.into())
     }
@@ -34,14 +36,14 @@ impl home::env::Env for TestProcess {
     }
 }
 
-impl home::env::Env for OSProcess {
+impl home::Env for OSProcess {
     fn home_dir(&self) -> Option<PathBuf> {
-        home::env::OS_ENV.home_dir()
+        home::OS_ENV.home_dir()
     }
     fn current_dir(&self) -> Result<PathBuf, io::Error> {
-        home::env::OS_ENV.current_dir()
+        home::OS_ENV.current_dir()
     }
     fn var_os(&self, key: &str) -> Option<OsString> {
-        home::env::OS_ENV.var_os(key)
+        home::OS_ENV.var_os(key)
     }
 }

src/utils/utils.rs

@@ -5,6 +5,7 @@ use std::io::{self, BufReader, Write};
 use std::path::{Path, PathBuf};
 
 use anyhow::{anyhow, bail, Context, Result};
+use home::env as home;
 use retry::delay::{jitter, Fibonacci};
 use retry::{retry, OperationResult};
 use sha2::Sha256;
@@ -493,11 +494,11 @@ pub(crate) fn to_absolute<P: AsRef<Path>>(path: P) -> Result<PathBuf> {
 }
 
 pub(crate) fn home_dir() -> Option<PathBuf> {
-    home::env::home_dir_with_env(&home_process())
+    home::home_dir_with_env(&home_process())
 }
 
 pub(crate) fn cargo_home() -> Result<PathBuf> {
-    home::env::cargo_home_with_env(&home_process()).context("failed to determine cargo home")
+    home::cargo_home_with_env(&home_process()).context("failed to determine cargo home")
 }
 
 // Creates a ~/.rustup folder
@@ -524,7 +525,7 @@ fn rustup_home_in_user_dir() -> Result<PathBuf> {
 }
 
 pub(crate) fn rustup_home() -> Result<PathBuf> {
-    home::env::rustup_home_with_env(&home_process()).context("failed to determine rustup home dir")
+    home::rustup_home_with_env(&home_process()).context("failed to determine rustup home dir")
 }
 
 pub(crate) fn format_path_for_display(path: &str) -> String {