dist: drop Copy derive from DownloadCfg

Author: djc

src/dist/download.rs

@@ -21,7 +21,7 @@ use crate::utils;
 
 const UPDATE_HASH_LEN: usize = 20;
 
-#[derive(Copy, Clone)]
+#[derive(Clone)]
 pub struct DownloadCfg<'a> {
     pub dist_root: &'a str,
     pub tmp_cx: &'a temp::Context,

src/dist/mod.rs

@@ -968,7 +968,7 @@ pub(crate) async fn update_from_dist(
     let mut toolchain = opts.toolchain.clone();
     let res = loop {
         let result = try_update_from_dist_(
-            opts.dl_cfg,
+            &opts.dl_cfg,
             opts.update_hash,
             &toolchain,
             match opts.exists {
@@ -1067,7 +1067,7 @@ pub(crate) async fn update_from_dist(
 
 #[allow(clippy::too_many_arguments)]
 async fn try_update_from_dist_(
-    download: DownloadCfg<'_>,
+    download: &DownloadCfg<'_>,
     update_hash: Option<&Path>,
     toolchain: &ToolchainDesc,
     profile: Option<Profile>,
@@ -1152,7 +1152,7 @@ async fn try_update_from_dist_(
                     &m,
                     changes,
                     force_update,
-                    &download,
+                    download,
                     &toolchain.manifest_name(),
                     true,
                 )
@@ -1233,7 +1233,7 @@ async fn try_update_from_dist_(
 }
 
 pub(crate) async fn dl_v2_manifest(
-    download: DownloadCfg<'_>,
+    download: &DownloadCfg<'_>,
     update_hash: Option<&Path>,
     toolchain: &ToolchainDesc,
 ) -> Result<Option<(ManifestV2, String)>> {
@@ -1282,7 +1282,7 @@ pub(crate) async fn dl_v2_manifest(
 }
 
 async fn dl_v1_manifest(
-    download: DownloadCfg<'_>,
+    download: &DownloadCfg<'_>,
     toolchain: &ToolchainDesc,
 ) -> Result<Vec<String>> {
     let root_url = toolchain.package_dir(download.dist_root);

src/toolchain/distributable.rs

@@ -526,7 +526,7 @@ impl<'a> DistributableToolchain<'a> {
         let update_hash = self.toolchain.cfg.get_hash_file(&self.desc, false)?;
         let download_cfg = DownloadCfg::new(self.toolchain.cfg);
 
-        match crate::dist::dl_v2_manifest(download_cfg, Some(&update_hash), &self.desc).await? {
+        match crate::dist::dl_v2_manifest(&download_cfg, Some(&update_hash), &self.desc).await? {
             Some((manifest, _)) => Ok(Some(manifest.get_rust_version()?.to_string())),
             None => Ok(None),
         }