notifications: log directly after failing to determine memory limit

Author: djc

src/dist/component/package.rs

@@ -10,7 +10,7 @@ use std::path::{Path, PathBuf};
 
 use anyhow::{Context, Result, anyhow, bail};
 use tar::EntryType;
-use tracing::warn;
+use tracing::{error, warn};
 
 use crate::diskio::{CompletedIo, Executor, FileBuffer, IO_CHUNK_SIZE, Item, Kind, get_executor};
 use crate::dist::component::components::*;
@@ -290,10 +290,8 @@ fn unpack_without_first_dir<R: Read>(
     let entries = archive.entries()?;
     let effective_max_ram = match effective_limits::memory_limit() {
         Ok(ram) => Some(ram as usize),
-        Err(e) => {
-            if let Some(h) = cx.notify_handler {
-                h(Notification::Error(e.to_string()))
-            }
+        Err(error) => {
+            error!("can't determine memory limit: {error}");
             None
         }
     };

src/notifications.rs

@@ -41,7 +41,6 @@ pub(crate) enum Notification<'a> {
     /// member, but the notification callback is already narrowed to
     /// utils::notifications by the time tar unpacking is called.
     SetDefaultBufferSize(usize),
-    Error(String),
     SetAutoInstall(&'a str),
     SetDefaultToolchain(Option<&'a ToolchainName>),
     SetOverrideToolchain(&'a Path, &'a str),
@@ -91,7 +90,6 @@ impl Notification<'_> {
             | DownloadFinished(_)
             | DownloadFailed(_)
             | ResumingPartialDownload => NotificationLevel::Debug,
-            Error(_) => NotificationLevel::Error,
             ToolchainDirectory(_)
             | LookingForToolchain(_)
             | InstallingToolchain(_)
@@ -189,7 +187,6 @@ impl Display for Notification<'_> {
                 write!(f, "Force-skipping unavailable component '{component}'")
             }
             RetryingDownload(url) => write!(f, "retrying download for '{url}'"),
-            Error(e) => write!(f, "error: '{e}'"),
             SetDefaultBufferSize(size) => write!(
                 f,
                 "using up to {} of RAM to unpack components",