Add cargo-make support (#4191)

Author: topecongiro

.cargo/Makefile.toml

@@ -0,0 +1,14 @@
+# This Makefile.toml defines common tasks and settings used in the rustfmt project.
+
+[env]
+CFG_RELEASE = { value = "nightly", condition = { env_not_set = ["CFG_RELEASE"] } }
+CFG_RELEASE_CHANNEL = { value = "nightly", condition = { env_not_set = ["CFG_RELEASE_CHANNEL"] } }
+
+[tasks.b]
+alias = "build"
+
+[tasks.c]
+alias = "check"
+
+[tasks.t]
+alias = "test"

.cargo/config

@@ -39,13 +39,15 @@ jobs:
         override: true
         profile: minimal
         default: true
+
+    - name: cargo-make
+      run: cargo install --force cargo-make
+
     - name: build
       run: |
         rustc -Vv
         cargo -V
-        cargo build --manifest-path rustfmt-core/Cargo.toml --workspace
+        cargo make build
 
     - name: test
-      run: cargo test-all
-    - name: test ignored
-      run: cargo test-all -- --ignored
+      run: cargo make test

.github/workflows/linux.yml

@@ -32,13 +32,15 @@ jobs:
         override: true
         profile: minimal
         default: true
+
+    - name: cargo-make
+      run: cargo install --force cargo-make
+
     - name: build
       run: |
         rustc -Vv
         cargo -V
-        cargo build --manifest-path rustfmt-core/Cargo.toml --workspace
+        cargo make build
 
     - name: test
-      run: cargo test-all
-    - name: test ignored
-      run: cargo test-all -- --ignored
+      run: cargo make test

.github/workflows/mac.yml

@@ -82,16 +82,17 @@ jobs:
         override: true
         profile: minimal
         default: true
+
+    - name: cargo-make
+      run: cargo install --force cargo-make
+
     - name: build
       run: |
         rustc -Vv
         cargo -V
-        cargo build --manifest-path rustfmt-core/Cargo.toml --workspace
+        cargo make build
       shell: cmd
 
     - name: test
-      run: cargo test-all
-      shell: cmd
-    - name: test ignored
-      run: cargo test-all -- --ignored
+      run: cargo make test
       shell: cmd

.github/workflows/windows.yml

@@ -45,8 +45,8 @@ matrix:
 
 script:
   - |
-   export CFG_RELEASE_CHANNEL=nightly
-   export CFG_RELEASE=nightly
+    export CFG_RELEASE_CHANNEL=nightly
+    export CFG_RELEASE=nightly
     if [ -z ${INTEGRATION} ]; then
       cargo build && cargo test && cargo test -- --ignored && cargo test --manifest-path rustfmt-core/Cargo.toml && cargo test --manifest-path rustfmt-core/Cargo.toml -- --ignored
     else

.travis.yml

@@ -0,0 +1,41 @@
+extend = ".cargo/Makefile.toml"
+
+[tasks.build]
+clear = true
+command = "cargo"
+args = [
+  "build",
+  "--manifest-path",
+  "rustfmt-core/Cargo.toml",
+  "--workspace",
+]
+
+[tasks.install]
+command = "cargo"
+args = [
+  "install",
+  "--path",
+  ".",
+  "--force",
+  "--locked",
+]
+
+[tasks.test]
+clear = true
+run_task = { name = ["test-bin", "test-lib"] }
+
+[tasks.test-bin]
+env = { "RUSTFMT_MAKE_MANIFEST_PATH" = "rustfmt-core/rustfmt-bin/Cargo.toml" }
+run_task = "test-subproject"
+
+[tasks.test-lib]
+env = { "RUSTFMT_MAKE_MANIFEST_PATH" = "rustfmt-core/rustfmt-lib/Cargo.toml" }
+run_task = "test-subproject"
+
+[tasks.test-subproject]
+condition = { env_set = ["RUSTFMT_MAKE_MANIFEST_PATH"] }
+script_runner = "@shell"
+script = [
+  "cargo test --manifest-path ${RUSTFMT_MAKE_MANIFEST_PATH}",
+  "cargo test --manifest-path ${RUSTFMT_MAKE_MANIFEST_PATH} -- --ignored",
+]

Makefile.toml

@@ -4,22 +4,8 @@ set -ex
 
 : ${INTEGRATION?"The INTEGRATION environment variable must be set."}
 
-# FIXME: this means we can get a stale cargo-fmt from a previous run.
-#
-# `which rustfmt` fails if rustfmt is not found. Since we don't install
-# `rustfmt` via `rustup`, this is the case unless we manually install it. Once
-# that happens, `cargo install --force` will be called, which installs
-# `rustfmt`, `cargo-fmt`, etc to `~/.cargo/bin`. This directory is cached by
-# travis (see `.travis.yml`'s "cache" key), such that build-bots that arrive
-# here after the first installation will find `rustfmt` and won't need to build
-# it again.
-#
-#which cargo-fmt || cargo install --force
-
-export CFG_RELEASE_CHANNEL=nightly
-export CFG_RELEASE=nightly
-
-cargo install --path . --force --locked
+which cargo-make || cargo install --force cargo-make
+cargo make install
 
 echo "Integration tests for: ${INTEGRATION}"
 cargo fmt -- --version

ci/integration.sh

@@ -0,0 +1,4 @@
+extend = { path = "../.cargo/Makefile.toml" }
+
+[env]
+CARGO_MAKE_EXTEND_WORKSPACE_MAKEFILE = "true"

rustfmt-core/Makefile.toml

@@ -0,0 +1 @@
+extend = { path = "../Makefile.toml" }