Fix to remove messages to stderr when LTO is not suppported by using the new API gccjit::is_lto_supported

Author: antoyo

Cargo.lock

@@ -56,18 +56,18 @@ dependencies = [
 
 [[package]]
 name = "gccjit"
-version = "2.9.0"
+version = "2.10.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "4a0e310ef75f396cd11b2443b353d55376656ca92c13cba36f92b7aff346ac1a"
+checksum = "60362e038e71e4bdc1a5b23fb45e1aba587b5947fe0db58f4871d95608f89eca"
 dependencies = [
  "gccjit_sys",
 ]
 
 [[package]]
 name = "gccjit_sys"
-version = "0.8.2"
+version = "0.9.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "95ed7572b30cd32430294dde6fb70822d58e67c6846a548647e8739776a0125b"
+checksum = "ddd542c8414e122217551c6af6b7d33acf51a227aee85276f218c087525e01bb"
 dependencies = [
  "libc",
 ]

Cargo.toml

@@ -24,7 +24,7 @@ default = ["master"]
 [dependencies]
 object = { version = "0.37.0", default-features = false, features = ["std", "read"] }
 tempfile = "3.20"
-gccjit = "2.8"
+gccjit = "2.10"
 #gccjit = { git = "https://github.com/rust-lang/gccjit.rs" }
 
 # Local copy.
@@ -33,7 +33,6 @@ gccjit = "2.8"
 [dev-dependencies]
 boml = "0.3.1"
 lang_tester = "0.8.0"
-tempfile = "3.20.0"
 
 [profile.dev]
 # By compiling dependencies with optimizations, performing tests gets much faster.

src/lib.rs

@@ -202,39 +202,14 @@ impl CodegenBackend for GccCodegenBackend {
             **self.target_info.info.lock().expect("lock") = context.get_target_info();
         }
 
-        // While not required by the API, we gate this code on the master feature to make sure we
-        // don't abort the process while checking if LTO is supported.
-        // The following could will emit a fatal error if LTO is not supported and older versions
-        // of libgccjit (the ones without this commit:
-        // https://github.com/rust-lang/gcc/commit/a073b06800f064b3917a6113d4cc2a0c19a10fda) will
-        // abort on fatal errors.
         #[cfg(feature = "master")]
         {
-            // NOTE: try the LTO frontend and check if it errors out. If so, do not embed the bitcode.
-            let temp_dir = TempDir::new().expect("cannot create temporary directory");
-            let temp_file = temp_dir.keep().join("result.asm");
-            let context = Context::default();
-            let object_file_path = temp_file.to_str().expect("path to str");
-            context.compile_to_file(gccjit::OutputKind::ObjectFile, object_file_path);
-
-            //let temp_dir = TempDir::new().expect("cannot create temporary directory");
-            //let temp_file = temp_dir.into_path().join("result.asm");
-            let check_context = Context::default();
-            check_context.add_driver_option("-x");
-            check_context.add_driver_option("lto");
-            check_context.add_driver_option(object_file_path);
-            check_context.set_print_errors_to_stderr(false);
-            //context.compile_to_file(gccjit::OutputKind::ObjectFile, temp_file.to_str().expect("path to str"));
-            // FIXME: compile gives the error as expected, but compile_to_file doesn't.
-            check_context.compile();
-            let error = check_context.get_last_error();
-            let lto_supported = error == Ok(None);
+            let lto_supported = gccjit::is_lto_supported();
             LTO_SUPPORTED.store(lto_supported, Ordering::SeqCst);
             self.lto_supported.store(lto_supported, Ordering::SeqCst);
-        }
 
-        #[cfg(feature = "master")]
-        gccjit::set_global_personality_function_name(b"rust_eh_personality\0");
+            gccjit::set_global_personality_function_name(b"rust_eh_personality\0");
+        }
 
         #[cfg(not(feature = "master"))]
         {