Merge pull request #914 from rylev/update-ui

Update comparison page top UI

Author: rylev

site/src/comparison.rs

@@ -470,6 +470,9 @@ pub struct BenchmarkVariances {
 }
 
 impl BenchmarkVariances {
+    const NUM_PREVIOUS_COMMITS: usize = 100;
+    const MIN_PREVIOUS_COMMITS: usize = 50;
+
     async fn calculate(
         ctxt: &SiteCtxt,
         from: ArtifactId,
@@ -483,11 +486,11 @@ impl BenchmarkVariances {
             .set::<String>(Tag::Profile, selector::Selector::All)
             .set(Tag::ProcessStatistic, selector::Selector::One(stat));
 
-        let num_commits = 100;
-        let previous_commits = Arc::new(previous_commits(from, num_commits, master_commits));
-        if previous_commits.len() < num_commits {
-            return Ok(None);
-        }
+        let previous_commits = Arc::new(previous_commits(
+            from,
+            Self::NUM_PREVIOUS_COMMITS,
+            master_commits,
+        ));
         let mut previous_commit_series = ctxt
             .query::<Option<f64>>(query, previous_commits.clone())
             .await?;
@@ -504,6 +507,9 @@ impl BenchmarkVariances {
                 }
             }
         }
+        if variance_data.len() < Self::MIN_PREVIOUS_COMMITS {
+            return Ok(None);
+        }
 
         for (bench, results) in variance_data.iter_mut() {
             debug!("Calculating variance for: {}", bench);

site/static/bootstrap.html

@@ -281,7 +281,7 @@ <h3>This may take a while!</h3>
             window.location.search = params.toString();
         }
 
-        load_state(state => {
+        loadState(state => {
             let values = Object.assign({}, {
                 start: "",
                 end: "",