Enable the job queue by default

Author: Kobzol

site/src/github.rs

@@ -2,7 +2,7 @@ pub mod client;
 pub mod comparison_summary;
 
 use crate::api::github::Commit;
-use crate::job_queue::should_use_new_system;
+use crate::job_queue::should_use_job_queue;
 use crate::load::{MissingReason, SiteCtxt, TryCommit};
 use chrono::{DateTime, Utc};
 use serde::Deserialize;
@@ -279,7 +279,7 @@ pub async fn enqueue_shas(
         };
         let conn = ctxt.conn().await;
 
-        let queued = if should_use_new_system(pr_number) {
+        let queued = if should_use_job_queue(pr_number) {
             attach_shas_to_try_benchmark_request(
                 &*conn,
                 pr_number,

site/src/job_queue/mod.rs

@@ -13,18 +13,18 @@ use parking_lot::RwLock;
 use std::{str::FromStr, sync::Arc};
 use tokio::time::{self, Duration, MissedTickBehavior};
 
-pub fn run_new_queue() -> bool {
-    std::env::var("RUN_CRON")
+pub fn is_job_queue_enabled() -> bool {
+    std::env::var("USE_JOB_QUEUE")
         .ok()
         .and_then(|x| x.parse().ok())
-        .unwrap_or(false)
+        .unwrap_or(true)
 }
 
-/// rust-lang/rust PR that will be used for testing the new system.
-const TEST_PR_FOR_NEW_SYSTEM: u32 = 147039;
+/// rust-lang/rust PR that will be used for testing the job queue.
+const TEST_PR_FOR_JOB_QUEUE: u32 = 147039;
 
-pub fn should_use_new_system(pr: u32) -> bool {
-    run_new_queue() && pr == TEST_PR_FOR_NEW_SYSTEM
+pub fn should_use_job_queue(pr: u32) -> bool {
+    is_job_queue_enabled() && pr == TEST_PR_FOR_JOB_QUEUE
 }
 
 /// Store the latest master commits or do nothing if all of them are

site/src/main.rs

@@ -1,6 +1,6 @@
 use futures::future::FutureExt;
 use parking_lot::RwLock;
-use site::job_queue::{create_queue_process, run_new_queue};
+use site::job_queue::{create_queue_process, is_job_queue_enabled};
 use site::load;
 use std::env;
 use std::sync::Arc;
@@ -59,7 +59,7 @@ async fn main() {
 
     let server = site::server::start(ctxt.clone(), port).fuse();
 
-    if run_new_queue() {
+    if is_job_queue_enabled() {
         task::spawn(async move {
             create_queue_process(
                 ctxt.clone(),

site/src/request_handlers/github.rs

@@ -3,7 +3,7 @@ use crate::github::{
     client, enqueue_shas, parse_homu_comment, rollup_pr_number, unroll_rollup,
     COMMENT_MARK_TEMPORARY, RUST_REPO_GITHUB_API_URL,
 };
-use crate::job_queue::should_use_new_system;
+use crate::job_queue::should_use_job_queue;
 use crate::load::SiteCtxt;
 
 use database::BenchmarkRequest;
@@ -117,7 +117,7 @@ async fn handle_rust_timer(
             Ok(cmd) => {
                 let conn = ctxt.conn().await;
 
-                if should_use_new_system(issue.number) {
+                if should_use_job_queue(issue.number) {
                     record_try_benchmark_request_without_artifacts(
                         &*conn,
                         issue.number,
@@ -166,7 +166,7 @@ async fn handle_rust_timer(
     {
         let conn = ctxt.conn().await;
         for command in &valid_build_cmds {
-            if should_use_new_system(issue.number) {
+            if should_use_job_queue(issue.number) {
                 record_try_benchmark_request_without_artifacts(
                     &*conn,
                     issue.number,