Merge pull request #1348 from rust-lang/artifact-sizes

Store artifact sizes into the database

Author: Mark-Simulacrum

collector/src/execute.rs

@@ -839,7 +839,11 @@ impl<'a> Processor for BenchProcessor<'a> {
         output: process::Output,
     ) -> anyhow::Result<Retry> {
         match process_stat_output(output) {
-            Ok(res) => {
+            Ok(mut res) => {
+                if let Some(ref profile) = res.1 {
+                    store_artifact_sizes_into_stats(&mut res.0, profile);
+                }
+
                 match data.scenario {
                     Scenario::Full => {
                         self.insert_stats(database::Scenario::Empty, data.profile, res);
@@ -885,6 +889,14 @@ impl<'a> Processor for BenchProcessor<'a> {
     }
 }
 
+fn store_artifact_sizes_into_stats(stats: &mut Stats, profile: &SelfProfile) {
+    for artifact in profile.artifact_sizes.iter() {
+        stats
+            .stats
+            .insert(format!("size:{}", artifact.label), artifact.size as f64);
+    }
+}
+
 pub struct ProfileProcessor<'a> {
     profiler: Profiler,
     output_dir: &'a Path,
@@ -1713,6 +1725,14 @@ impl Patch {
 #[derive(serde::Deserialize, Clone)]
 pub struct SelfProfile {
     pub query_data: Vec<QueryData>,
+    pub artifact_sizes: Vec<ArtifactSize>,
+}
+
+#[derive(serde::Deserialize, Clone)]
+pub struct ArtifactSize {
+    pub label: QueryLabel,
+    #[serde(rename = "value")]
+    pub size: u64,
 }
 
 #[derive(serde::Deserialize, Clone)]

site/src/comparison.rs

@@ -206,6 +206,18 @@ pub enum Metric {
     TaskClockUser,
     #[serde(rename = "wall-time")]
     WallTime,
+    #[serde(rename = "size:codegen_unit_size_estimate")]
+    CodegenUnitSize,
+    #[serde(rename = "size:dep_graph")]
+    DepGraphSize,
+    #[serde(rename = "size:linked_artifact")]
+    LinkedArtifactSize,
+    #[serde(rename = "size:object_file")]
+    ObjectFileSize,
+    #[serde(rename = "size:query_cache")]
+    QueryCacheSize,
+    #[serde(rename = "size:work_product_index")]
+    WorkProductIndexSize,
 }
 
 impl Metric {
@@ -222,6 +234,12 @@ impl Metric {
             Metric::TaskClock => "task-clock",
             Metric::TaskClockUser => "task-clock:u",
             Metric::WallTime => "wall-time",
+            Metric::CodegenUnitSize => "size:codegen_unit_size_estimate",
+            Metric::DepGraphSize => "size:dep_graph",
+            Metric::LinkedArtifactSize => "size:linked_artifact",
+            Metric::ObjectFileSize => "size:object_file",
+            Metric::QueryCacheSize => "size:query_cache",
+            Metric::WorkProductIndexSize => "size:work_product_index",
         }
     }