PR Feedback; use Object.keys(errors).length !== 0

Jamesbarford · Jamesbarford · commit 6913885c263c · 2025-09-03T13:28:45.000+01:00
diff --git a/site/frontend/src/pages/status_new/page.vue b/site/frontend/src/pages/status_new/page.vue
@@ -99,13 +99,7 @@ function formatStatus(status: BenchmarkRequestStatus): string {
 }
 
 function hasErrors(errors: Dict<string>) {
-  // This is a bit odd but if the error object has values the loop will be
-  // hit and thus return true.
-  for (const key in errors) {
-    console.log(key);
-    return true;
-  }
-  return false;
+  return Object.keys(errors).length !== 0;
 }
 
 function getErrorsLength(errors: Dict<string>) {

Original file line number	Diff line number	Diff line change
`@@ -99,13 +99,7 @@ function formatStatus(status: BenchmarkRequestStatus): string {`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`function hasErrors(errors: Dict<string>) {`
`102`		`- // This is a bit odd but if the error object has values the loop will be`
`103`		`- // hit and thus return true.`
`104`		`- for (const key in errors) {`
`105`		`- console.log(key);`
`106`		`- return true;`
`107`		`- }`
`108`		`- return false;`
	`102`	`+ return Object.keys(errors).length !== 0;`
`109`	`103`	`}`
`110`	`104`
`111`	`105`	`function getErrorsLength(errors: Dict<string>) {`