Skip to content

Commit 3ee9cc1

Browse files
Mark-SimulacrumMark-Simulacrum
authored
Merge pull request #1386 from nnethercote/better-emoji
Change 😿🎉 to ❌✅ in github comments.
2 parents 76b47ba + 60824e1 commit 3ee9cc1

File tree

2 files changed

+47
-47
lines changed

2 files changed

+47
-47
lines changed

‎site/src/comparison.rs‎

Lines changed: 45 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -499,11 +499,11 @@ pub fn write_summary_table(
499499

500500
// label
501501
column_data.push(vec![
502-
"Regressions 😿 <br /> (primary)".to_string(),
503-
"Regressions 😿 <br /> (secondary)".to_string(),
504-
"Improvements 🎉 <br /> (primary)".to_string(),
505-
"Improvements 🎉 <br /> (secondary)".to_string(),
506-
"All 😿🎉 (primary)".to_string(),
502+
"Regressions ❌ <br /> (primary)".to_string(),
503+
"Regressions ❌ <br /> (secondary)".to_string(),
504+
"Improvements ✅ <br /> (primary)".to_string(),
505+
"Improvements ✅ <br /> (secondary)".to_string(),
506+
"All ❌✅ (primary)".to_string(),
507507
]);
508508

509509
// mean
@@ -1340,11 +1340,11 @@ mod tests {
13401340
r#"
13411341
| | mean[^1] | max | count[^2] |
13421342
|:----------:|:--------:|:---:|:---------:|
1343-
| Regressions 😿 <br /> (primary) | 146.7% | 200.0% | 3 |
1344-
| Regressions 😿 <br /> (secondary) | N/A | N/A | 0 |
1345-
| Improvements 🎉 <br /> (primary) | N/A | N/A | 0 |
1346-
| Improvements 🎉 <br /> (secondary) | N/A | N/A | 0 |
1347-
| All 😿🎉 (primary) | 146.7% | 200.0% | 3 |
1343+
| Regressions ❌ <br /> (primary) | 146.7% | 200.0% | 3 |
1344+
| Regressions ❌ <br /> (secondary) | N/A | N/A | 0 |
1345+
| Improvements ✅ <br /> (primary) | N/A | N/A | 0 |
1346+
| Improvements ✅ <br /> (secondary) | N/A | N/A | 0 |
1347+
| All ❌✅ (primary) | 146.7% | 200.0% | 3 |
13481348
"#
13491349
.trim_start(),
13501350
);
@@ -1361,11 +1361,11 @@ mod tests {
13611361
r#"
13621362
| | mean[^1] | max | count[^2] |
13631363
|:----------:|:--------:|:---:|:---------:|
1364-
| Regressions 😿 <br /> (primary) | N/A | N/A | 0 |
1365-
| Regressions 😿 <br /> (secondary) | N/A | N/A | 0 |
1366-
| Improvements 🎉 <br /> (primary) | -71.7% | -80.0% | 3 |
1367-
| Improvements 🎉 <br /> (secondary) | N/A | N/A | 0 |
1368-
| All 😿🎉 (primary) | -71.7% | -80.0% | 3 |
1364+
| Regressions ❌ <br /> (primary) | N/A | N/A | 0 |
1365+
| Regressions ❌ <br /> (secondary) | N/A | N/A | 0 |
1366+
| Improvements ✅ <br /> (primary) | -71.7% | -80.0% | 3 |
1367+
| Improvements ✅ <br /> (secondary) | N/A | N/A | 0 |
1368+
| All ❌✅ (primary) | -71.7% | -80.0% | 3 |
13691369
"#
13701370
.trim_start(),
13711371
);
@@ -1382,11 +1382,11 @@ mod tests {
13821382
r#"
13831383
| | mean[^1] | max | count[^2] |
13841384
|:----------:|:--------:|:---:|:---------:|
1385-
| Regressions 😿 <br /> (primary) | N/A | N/A | 0 |
1386-
| Regressions 😿 <br /> (secondary) | N/A | N/A | 0 |
1387-
| Improvements 🎉 <br /> (primary) | N/A | N/A | 0 |
1388-
| Improvements 🎉 <br /> (secondary) | -71.7% | -80.0% | 3 |
1389-
| All 😿🎉 (primary) | N/A | N/A | 0 |
1385+
| Regressions ❌ <br /> (primary) | N/A | N/A | 0 |
1386+
| Regressions ❌ <br /> (secondary) | N/A | N/A | 0 |
1387+
| Improvements ✅ <br /> (primary) | N/A | N/A | 0 |
1388+
| Improvements ✅ <br /> (secondary) | -71.7% | -80.0% | 3 |
1389+
| All ❌✅ (primary) | N/A | N/A | 0 |
13901390
"#
13911391
.trim_start(),
13921392
);
@@ -1403,11 +1403,11 @@ mod tests {
14031403
r#"
14041404
| | mean[^1] | max | count[^2] |
14051405
|:----------:|:--------:|:---:|:---------:|
1406-
| Regressions 😿 <br /> (primary) | N/A | N/A | 0 |
1407-
| Regressions 😿 <br /> (secondary) | 146.7% | 200.0% | 3 |
1408-
| Improvements 🎉 <br /> (primary) | N/A | N/A | 0 |
1409-
| Improvements 🎉 <br /> (secondary) | N/A | N/A | 0 |
1410-
| All 😿🎉 (primary) | N/A | N/A | 0 |
1406+
| Regressions ❌ <br /> (primary) | N/A | N/A | 0 |
1407+
| Regressions ❌ <br /> (secondary) | 146.7% | 200.0% | 3 |
1408+
| Improvements ✅ <br /> (primary) | N/A | N/A | 0 |
1409+
| Improvements ✅ <br /> (secondary) | N/A | N/A | 0 |
1410+
| All ❌✅ (primary) | N/A | N/A | 0 |
14111411
"#
14121412
.trim_start(),
14131413
);
@@ -1425,11 +1425,11 @@ mod tests {
14251425
r#"
14261426
| | mean[^1] | max | count[^2] |
14271427
|:----------:|:--------:|:---:|:---------:|
1428-
| Regressions 😿 <br /> (primary) | 150.0% | 200.0% | 2 |
1429-
| Regressions 😿 <br /> (secondary) | N/A | N/A | 0 |
1430-
| Improvements 🎉 <br /> (primary) | -62.5% | -75.0% | 2 |
1431-
| Improvements 🎉 <br /> (secondary) | N/A | N/A | 0 |
1432-
| All 😿🎉 (primary) | 43.8% | 200.0% | 4 |
1428+
| Regressions ❌ <br /> (primary) | 150.0% | 200.0% | 2 |
1429+
| Regressions ❌ <br /> (secondary) | N/A | N/A | 0 |
1430+
| Improvements ✅ <br /> (primary) | -62.5% | -75.0% | 2 |
1431+
| Improvements ✅ <br /> (secondary) | N/A | N/A | 0 |
1432+
| All ❌✅ (primary) | 43.8% | 200.0% | 4 |
14331433
"#
14341434
.trim_start(),
14351435
);
@@ -1449,11 +1449,11 @@ mod tests {
14491449
r#"
14501450
| | mean[^1] | max | count[^2] |
14511451
|:----------:|:--------:|:---:|:---------:|
1452-
| Regressions 😿 <br /> (primary) | 150.0% | 200.0% | 2 |
1453-
| Regressions 😿 <br /> (secondary) | 100.0% | 100.0% | 1 |
1454-
| Improvements 🎉 <br /> (primary) | -62.5% | -75.0% | 2 |
1455-
| Improvements 🎉 <br /> (secondary) | -66.7% | -66.7% | 1 |
1456-
| All 😿🎉 (primary) | 43.8% | 200.0% | 4 |
1452+
| Regressions ❌ <br /> (primary) | 150.0% | 200.0% | 2 |
1453+
| Regressions ❌ <br /> (secondary) | 100.0% | 100.0% | 1 |
1454+
| Improvements ✅ <br /> (primary) | -62.5% | -75.0% | 2 |
1455+
| Improvements ✅ <br /> (secondary) | -66.7% | -66.7% | 1 |
1456+
| All ❌✅ (primary) | 43.8% | 200.0% | 4 |
14571457
"#
14581458
.trim_start(),
14591459
);
@@ -1469,11 +1469,11 @@ mod tests {
14691469
r#"
14701470
| | mean[^1] | max | count[^2] |
14711471
|:----------:|:--------:|:---:|:---------:|
1472-
| Regressions 😿 <br /> (primary) | 20.0% | 20.0% | 1 |
1473-
| Regressions 😿 <br /> (secondary) | N/A | N/A | 0 |
1474-
| Improvements 🎉 <br /> (primary) | -50.0% | -50.0% | 1 |
1475-
| Improvements 🎉 <br /> (secondary) | N/A | N/A | 0 |
1476-
| All 😿🎉 (primary) | -15.0% | -50.0% | 2 |
1472+
| Regressions ❌ <br /> (primary) | 20.0% | 20.0% | 1 |
1473+
| Regressions ❌ <br /> (secondary) | N/A | N/A | 0 |
1474+
| Improvements ✅ <br /> (primary) | -50.0% | -50.0% | 1 |
1475+
| Improvements ✅ <br /> (secondary) | N/A | N/A | 0 |
1476+
| All ❌✅ (primary) | -15.0% | -50.0% | 2 |
14771477
"#
14781478
.trim_start(),
14791479
);
@@ -1489,11 +1489,11 @@ mod tests {
14891489
r#"
14901490
| | mean[^1] | max | count[^2] |
14911491
|:----------:|:--------:|:---:|:---------:|
1492-
| Regressions 😿 <br /> (primary) | 100.0% | 100.0% | 1 |
1493-
| Regressions 😿 <br /> (secondary) | N/A | N/A | 0 |
1494-
| Improvements 🎉 <br /> (primary) | -16.7% | -16.7% | 1 |
1495-
| Improvements 🎉 <br /> (secondary) | N/A | N/A | 0 |
1496-
| All 😿🎉 (primary) | 41.7% | 100.0% | 2 |
1492+
| Regressions ❌ <br /> (primary) | 100.0% | 100.0% | 1 |
1493+
| Regressions ❌ <br /> (secondary) | N/A | N/A | 0 |
1494+
| Improvements ✅ <br /> (primary) | -16.7% | -16.7% | 1 |
1495+
| Improvements ✅ <br /> (secondary) | N/A | N/A | 0 |
1496+
| All ❌✅ (primary) | 41.7% | 100.0% | 2 |
14971497
"#
14981498
.trim_start(),
14991499
);

‎site/src/github/comparison_summary.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -304,11 +304,11 @@ fn generate_short_summary(summary: &ArtifactComparisonSummary) -> String {
304304

305305
match summary.direction() {
306306
Some(Direction::Improvement) => format!(
307-
"🎉 relevant {} found",
307+
"✅ relevant {} found",
308308
ending("improvement", num_improvements)
309309
),
310310
Some(Direction::Regression) => format!(
311-
"😿 relevant {} found",
311+
"❌ relevant {} found",
312312
ending("regression", num_regressions)
313313
),
314314
Some(Direction::Mixed) => "mixed results".to_string(),

0 commit comments

Comments
 (0)