Fix Clippy

Author: Kobzol

collector/src/bin/collector.rs

@@ -1528,24 +1528,19 @@ async fn run_benchmark_job(
             Toolchain::from_sysroot(&sysroot, commit.sha.clone())
         }
         ArtifactId::Tag(tag) => {
-            create_toolchain_from_published_version(&tag, job.target().as_str())?
+            create_toolchain_from_published_version(tag, job.target().as_str())?
         }
     };
     log::info!("Sysroot download finished");
 
-    let (compile_config, runtime_config) = create_benchmark_configs(
-        conn,
-        &toolchain,
-        &artifact_id,
-        &job,
-        &all_compile_benchmarks,
-    )
-    .await
-    .map_err(|error| {
-        BenchmarkJobError::Permanent(anyhow::anyhow!(
-            "Cannot prepare benchmark configs: {error:?}"
-        ))
-    })?;
+    let (compile_config, runtime_config) =
+        create_benchmark_configs(conn, &toolchain, &artifact_id, job, all_compile_benchmarks)
+            .await
+            .map_err(|error| {
+                BenchmarkJobError::Permanent(anyhow::anyhow!(
+                    "Cannot prepare benchmark configs: {error:?}"
+                ))
+            })?;
 
     let shared = SharedBenchmarkConfig {
         artifact_id,
@@ -1594,7 +1589,7 @@ async fn create_benchmark_configs(
     let compile_config = if bench_rustc || !bench_compile_benchmarks.is_empty() {
         Some(CompileBenchmarkConfig {
             benchmarks: all_compile_benchmarks
-                .into_iter()
+                .iter()
                 .filter(|b| bench_compile_benchmarks.contains(&b.name))
                 .cloned()
                 .collect(),

database/src/pool.rs

@@ -1152,11 +1152,11 @@ mod tests {
 
             assert_eq!(collector_configs[0].name(), collector_name_one);
             assert_eq!(collector_configs[0].benchmark_set(), benchmark_set_one);
-            assert_eq!(collector_configs[0].is_active(), true);
+            assert!(collector_configs[0].is_active());
 
             assert_eq!(collector_configs[1].name(), collector_name_two);
             assert_eq!(collector_configs[1].benchmark_set(), benchmark_set_two);
-            assert_eq!(collector_configs[1].is_active(), true);
+            assert!(collector_configs[1].is_active());
 
             Ok(ctx)
         })

site/src/request_handlers/github.rs

@@ -464,7 +464,7 @@ Otherwise LGTM."#),
             @r#"Some(Ok(QueueCommand { params: BenchmarkParameters { include: Some("foo,bar"), exclude: None, runs: None, backends: None } }))"#);
     }
 
-    fn get_build_commands(body: &str) -> Vec<Result<BuildCommand, String>> {
+    fn get_build_commands(body: &str) -> Vec<Result<BuildCommand<'_>, String>> {
         parse_build_commands(body).collect()
     }