Prefer slice patterns over length check and indexing

Author: oli-obk

collector/src/bin/collector.rs

@@ -1158,10 +1158,10 @@ fn main_result() -> anyhow::Result<i32> {
                         scenarios,
                         &mut errors,
                     );
-                    if diffs.len() == 1 {
+                    if let [diff] = &diffs[..] {
                         let short = out_dir.join("cgann-diff-latest");
-                        std::fs::copy(&diffs[0], &short).expect("copy to short path");
-                        eprintln!("Original diff at: {}", diffs[0].to_string_lossy());
+                        std::fs::copy(diff, &short).expect("copy to short path");
+                        eprintln!("Original diff at: {}", diff.to_string_lossy());
                         eprintln!("Short path: {}", short.to_string_lossy());
                     } else {
                         eprintln!("Diffs:");

collector/src/compare.rs

@@ -80,8 +80,8 @@ pub async fn compare_artifacts(
         None => select_artifact_id("base", &aids)?.to_string(),
     };
     aids.retain(|id| id != &base);
-    let modified = if aids.len() == 1 {
-        let new_modified = aids[0].clone();
+    let modified = if let [new_modified] = &aids[..] {
+        let new_modified = new_modified.clone();
         println!(
             "Only 1 artifact remains, automatically selecting: {}",
             new_modified