Emit an error for invalid item of instruction_set #129002
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
chansuke
force-pushed
the
fix/instruction_set
branch
from
256ac63 to
92fbd2c
Compare
Collaborator
|
☔ The latest upstream changes (presumably #129202) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
@chansuke if you can resolve the conflicts we can then push this pr forward. Thanks |
Dylan-DPC
added
S-waiting-on-author
wesleywiser
reviewed
Nov 8, 2024
chansuke
force-pushed
the
fix/instruction_set
branch
from
92fbd2c to
35363d5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
chansuke
force-pushed
the
fix/instruction_set
branch
from
4ad825d to
d696b47
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
chansuke
force-pushed
the
fix/instruction_set
branch
from
564be4b to
f3a6be9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
@chansuke |
chansuke
force-pushed
the
fix/instruction_set
branch
from
9885bc3 to
8239a37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #128489
Emit an error on invalid item of
instruction_set.This PR merges the instruction_set error handling into rustc_passes/check_attr.rs. This change was necessary because the codegen_attrs only handle the
Fntarget.