Address final review

Author: mati865

src/ci/docker/scripts/musl-toolchain.sh

@@ -1,3 +1,9 @@
+# This script runs `musl-cross-make` to prepare C toolchain (Binutils, GCC, musl itself)
+# and builds static libunwind that we distribute for static target.
+#
+# Versions of the toolchain components are configurable in `musl-cross-make/Makefile` and
+# musl unlike GLIBC is forward compatible so upgrading it shouldn't break old distributions.
+# Right now we have: Binutils 2.27, GCC 6.3.0, musl 1.1.18
 set -ex
 
 hide_output() {

src/ci/docker/test-various/Dockerfile

@@ -12,7 +12,6 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
   sudo \
   gdb \
   xz-utils \
-  # for musl
   wget \
   patch
 
@@ -25,9 +24,7 @@ RUN curl -sL https://nodejs.org/dist/v9.2.0/node-v9.2.0-linux-x64.tar.xz | \
 
 WORKDIR /build/
 COPY scripts/musl-toolchain.sh /build/
-RUN CFLAGS="-Wa,-mrelax-relocations=no" \
-    CXXFLAGS="-Wa,-mrelax-relocations=no" \
-    bash musl-toolchain.sh x86_64 && rm -rf build
+RUN bash musl-toolchain.sh x86_64 && rm -rf build
 WORKDIR /
 
 COPY scripts/sccache.sh /scripts/