Rename buffer_non_error_diag as buffer_non_error.

To match `buffer_error`.

Author: nnethercote

compiler/rustc_borrowck/src/diagnostics/outlives_suggestion.rs

@@ -251,6 +251,6 @@ impl OutlivesSuggestionBuilder {
         diag.sort_span = mir_span.shrink_to_hi();
 
         // Buffer the diagnostic
-        mbcx.buffer_non_error_diag(diag);
+        mbcx.buffer_non_error(diag);
     }
 }

compiler/rustc_borrowck/src/lib.rs

@@ -2435,7 +2435,7 @@ mod error {
             self.buffered.push(t.into_diagnostic());
         }
 
-        pub fn buffer_non_error_diag(&mut self, t: DiagnosticBuilder<'_, ()>) {
+        pub fn buffer_non_error(&mut self, t: DiagnosticBuilder<'_, ()>) {
             self.buffered.push(t.into_diagnostic());
         }
 
@@ -2449,8 +2449,8 @@ mod error {
             self.errors.buffer_error(t);
         }
 
-        pub fn buffer_non_error_diag(&mut self, t: DiagnosticBuilder<'_, ()>) {
-            self.errors.buffer_non_error_diag(t);
+        pub fn buffer_non_error(&mut self, t: DiagnosticBuilder<'_, ()>) {
+            self.errors.buffer_non_error(t);
         }
 
         pub fn buffer_move_error(

compiler/rustc_borrowck/src/nll.rs

@@ -310,7 +310,7 @@ pub(super) fn dump_annotation<'tcx>(
         err.note(format!("Inferred opaque type values:\n{opaque_type_values:#?}"));
     }
 
-    errors.buffer_non_error_diag(err);
+    errors.buffer_non_error(err);
 }
 
 fn for_each_region_constraint<'tcx>(