address review

Author: LorrensP-2158466

compiler/rustc_resolve/src/imports.rs

@@ -830,7 +830,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
         let mut indeterminate_count = 0;
         self.per_ns(|this, ns| {
             if !type_ns_only || ns == TypeNS {
-                let Progress::Pending = bindings[ns].get() else {
+                if bindings[ns].get() != Progress::Pending {
                     return;
                 };
                 let binding_result = this.maybe_resolve_ident_in_module(
@@ -843,9 +843,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
                 let parent = import.parent_scope.module;
                 let binding = match binding_result {
                     Ok(binding) => {
-                        // We need the `target`, `source` can be extracted.
-                        let imported_binding = this.import(binding, import);
-                        if imported_binding.is_assoc_item()
+                        if binding.is_assoc_item()
                             && !this.tcx.features().import_trait_associated_functions()
                         {
                             feature_err(
@@ -856,6 +854,8 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
                             )
                             .emit();
                         }
+                        // We need the `target`, `source` can be extracted.
+                        let imported_binding = this.import(binding, import);
                         this.define(parent, target, ns, imported_binding);
                         Poll::Ready(Some(imported_binding))
                     }