Skip to content

Commit d3ee1c2

Browse files
committed
Small refactor of Mingw step
1 parent 5c7f4d4 commit d3ee1c2

File tree

1 file changed

+12
-12
lines changed
  • src/bootstrap/src/core/build_steps

1 file changed

+12
-12
lines changed

src/bootstrap/src/core/build_steps/dist.rs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -363,9 +363,13 @@ fn get_cc_search_dirs(
363363
(bin_path, lib_path)
364364
}
365365

366+
/// Builds the `rust-mingw` installer component.
367+
///
368+
/// This contains all the bits and pieces to run the MinGW Windows targets
369+
/// without any extra installed software (e.g., we bundle gcc, libraries, etc.).
366370
#[derive(Debug, Clone, Hash, PartialEq, Eq)]
367371
pub struct Mingw {
368-
pub host: TargetSelection,
372+
target: TargetSelection,
369373
}
370374

371375
impl Step for Mingw {
@@ -377,29 +381,25 @@ impl Step for Mingw {
377381
}
378382

379383
fn make_run(run: RunConfig<'_>) {
380-
run.builder.ensure(Mingw { host: run.target });
384+
run.builder.ensure(Mingw { target: run.target });
381385
}
382386

383-
/// Builds the `rust-mingw` installer component.
384-
///
385-
/// This contains all the bits and pieces to run the MinGW Windows targets
386-
/// without any extra installed software (e.g., we bundle gcc, libraries, etc).
387387
fn run(self, builder: &Builder<'_>) -> Option<GeneratedTarball> {
388-
let host = self.host;
389-
if !host.ends_with("pc-windows-gnu") || !builder.config.dist_include_mingw_linker {
388+
let target = self.target;
389+
if !target.ends_with("pc-windows-gnu") || !builder.config.dist_include_mingw_linker {
390390
return None;
391391
}
392392

393-
let mut tarball = Tarball::new(builder, "rust-mingw", &host.triple);
393+
let mut tarball = Tarball::new(builder, "rust-mingw", &target.triple);
394394
tarball.set_product_name("Rust MinGW");
395395

396-
make_win_dist(tarball.image_dir(), host, builder);
396+
make_win_dist(tarball.image_dir(), target, builder);
397397

398398
Some(tarball.generate())
399399
}
400400

401401
fn metadata(&self) -> Option<StepMetadata> {
402-
Some(StepMetadata::dist("mingw", self.host))
402+
Some(StepMetadata::dist("mingw", self.target))
403403
}
404404
}
405405

@@ -1625,7 +1625,7 @@ impl Step for Extended {
16251625
tarballs.push(builder.ensure(Std { compiler, target }).expect("missing std"));
16261626

16271627
if target.is_windows_gnu() {
1628-
tarballs.push(builder.ensure(Mingw { host: target }).expect("missing mingw"));
1628+
tarballs.push(builder.ensure(Mingw { target }).expect("missing mingw"));
16291629
}
16301630

16311631
add_component!("rust-docs" => Docs { host: target });

0 commit comments

Comments
 (0)