Skip to content

Commit d221d41

Browse files
committed
rustc_target: rehome target_abi comment
1 parent 94eaaf2 commit d221d41

File tree

1 file changed

+6
-6
lines changed
  • compiler/rustc_target/src/spec/base/apple

1 file changed

+6
-6
lines changed

compiler/rustc_target/src/spec/base/apple/mod.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,12 @@ impl TargetEnv {
102102
}
103103
}
104104

105+
// NOTE: We originally set `cfg(target_abi = "macabi")` / `cfg(target_abi = "sim")`,
106+
// before it was discovered that those are actually environments:
107+
// https://github.com/rust-lang/rust/issues/133331
108+
//
109+
// But let's continue setting them for backwards compatibility.
110+
// FIXME(madsmtm): Warn about using these in the future.
105111
fn target_abi(self) -> Abi {
106112
match self {
107113
Self::Normal => Abi::Unspecified,
@@ -124,12 +130,6 @@ pub(crate) fn base(
124130
llvm_floatabi: Some(FloatAbi::Hard),
125131
os,
126132
env: env.target_env(),
127-
// NOTE: We originally set `cfg(target_abi = "macabi")` / `cfg(target_abi = "sim")`,
128-
// before it was discovered that those are actually environments:
129-
// https://github.com/rust-lang/rust/issues/133331
130-
//
131-
// But let's continue setting them for backwards compatibility.
132-
// FIXME(madsmtm): Warn about using these in the future.
133133
abi: env.target_abi(),
134134
cpu: arch.target_cpu(env).into(),
135135
link_env_remove,

0 commit comments

Comments
 (0)