clean up clone()

Author: Oneirical

tests/run-make/issue-11908/rmake.rs

@@ -15,21 +15,18 @@ use run_make_support::{dynamic_lib, rustc, tmp_dir};
 use std::fs;
 
 fn main() {
-    let mut tmp_dir_other = tmp_dir();
-    tmp_dir_other.push("other");
+    let tmp_dir_other = tmp_dir().join("other");
 
-    fs::create_dir(tmp_dir_other.clone());
+    fs::create_dir(&tmp_dir_other);
     rustc().input("foo.rs").crate_type("dylib").codegen_option("prefer-dynamic").run();
-    fs::rename(dynamic_lib("foo"), tmp_dir_other.clone());
+    fs::rename(dynamic_lib("foo"), &tmp_dir_other);
     rustc().input("foo.rs").crate_type("dylib").codegen_option("prefer-dynamic").run();
-    rustc().input("bar.rs").library_search_path(tmp_dir_other.clone()).run();
+    rustc().input("bar.rs").library_search_path(&tmp_dir_other).run();
     fs::remove_dir_all(tmp_dir());
 
-    fs::create_dir_all(tmp_dir_other.clone());
+    fs::create_dir_all(&tmp_dir_other);
     rustc().input("foo.rs").crate_type("rlib").run();
-    let mut tmp_dir_libfoo = tmp_dir();
-    tmp_dir_libfoo.push("libfoo.rlib");
-    fs::rename(tmp_dir_libfoo, tmp_dir_other.clone());
+    fs::rename(tmp_dir().join("libfoo.rlib"), &tmp_dir_other);
     rustc().input("foo.rs").crate_type("rlib").run();
-    rustc().input("bar.rs").library_search_path(tmp_dir_other.clone()).run();
+    rustc().input("bar.rs").library_search_path(tmp_dir_other).run();
 }