wip

Author: JonathanBrouwer

compiler/rustc_attr_parsing/src/attributes/codegen_attrs.rs

@@ -281,6 +281,7 @@ impl<S: Stage> NoArgsAttributeParser<S> for TrackCallerParser {
         Allow(Target::Method(MethodKind::Trait { body: false })),
         Allow(Target::ForeignFn),
         Allow(Target::Closure),
+        Warn(Target::MacroDef),
     ]);
     const CREATE: fn(Span) -> AttributeKind = AttributeKind::TrackCaller;
 }
@@ -303,6 +304,10 @@ impl<S: Stage> NoArgsAttributeParser<S> for NoMangleParser {
         Warn(Target::Impl { of_trait: true }),
         Warn(Target::Trait),
         Warn(Target::Mod),
+        Warn(Target::Const),
+        Warn(Target::Statement),
+        Warn(Target::ForeignFn),
+        Warn(Target::ForeignStatic),
     ]);
     const CREATE: fn(Span) -> AttributeKind = AttributeKind::NoMangle;
 }

compiler/rustc_attr_parsing/src/attributes/deprecation.rs

@@ -59,6 +59,7 @@ impl<S: Stage> SingleAttributeParser<S> for DeprecationParser {
         Warn(Target::Expression),
         Warn(Target::Impl { of_trait: false }),
         Warn(Target::Impl { of_trait: true }),
+        Warn(Target::Crate)
     ]);
     const TEMPLATE: AttributeTemplate = template!(
         Word,

compiler/rustc_attr_parsing/src/attributes/macro_attrs.rs

@@ -46,6 +46,7 @@ const MACRO_USE_ALLOWED_TARGETS: AllowedTargets = AllowedTargets::AllowList(&[
     Warn(Target::TyAlias),
     Warn(Target::Impl { of_trait: false }),
     Warn(Target::Impl { of_trait: true }),
+    Warn(Target::Use),
 ]);
 
 impl<S: Stage> AttributeParser<S> for MacroUseParser {

compiler/rustc_attr_parsing/src/attributes/must_use.rs

@@ -24,6 +24,7 @@ impl<S: Stage> SingleAttributeParser<S> for MustUseParser {
         Allow(Target::Method(MethodKind::Inherent)),
         Allow(Target::ForeignFn),
         Allow(Target::Trait),
+        Warn(Target::Method(MethodKind::Trait { body: true })),
         Warn(Target::Crate),
         Warn(Target::Mod),
         Warn(Target::TyAlias),

compiler/rustc_hir/src/target.rs

@@ -63,6 +63,7 @@ pub enum Target {
     // Used for attributes
     MacroCall,
     Crate,
+    Delegation,
 }
 
 impl Display for Target {
@@ -106,7 +107,8 @@ impl Target {
             | Target::ExprField
             | Target::MacroCall
             | Target::Crate
-            | Target::WherePredicate => false,
+            | Target::WherePredicate
+            | Target::Delegation => false,
         }
     }
 
@@ -233,12 +235,13 @@ impl Target {
                 MethodKind::Inherent
             }),
             AssocItemKind::Type(_) => Target::AssocTy,
+            AssocItemKind::Delegation(_) => Target::Delegation,
             _ => unreachable!(),
         }
     }
 
     pub fn from_expr(expr: &ast::Expr) -> Self {
-        if let ast::ExprKind::Closure(..) = expr.kind { Self::Closure } else { Self::Expression }
+        if let ast::ExprKind::Closure(..) | ast::ExprKind::Gen(..) = expr.kind { Self::Closure } else { Self::Expression }
     }
 
     pub fn name(self) -> &'static str {
@@ -287,6 +290,7 @@ impl Target {
             Target::WherePredicate => "where predicate",
             Target::MacroCall => "macro call",
             Target::Crate => "crate",
+            Target::Delegation => "delegation",
         }
     }
 }

compiler/rustc_passes/src/check_attr.rs

@@ -1057,7 +1057,8 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
             | Target::PatField
             | Target::ExprField
             | Target::Crate
-            | Target::MacroCall => None,
+            | Target::MacroCall
+            | Target::Delegation => None,
         } {
             tcx.dcx().emit_err(errors::DocAliasBadLocation { span, attr_str, location });
             return;
@@ -2329,7 +2330,8 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
             | Target::ExprField
             | Target::WherePredicate
             | Target::Crate
-            | Target::MacroCall => {
+            | Target::MacroCall
+            | Target::Delegation => {
                 self.tcx.dcx().emit_err(errors::RustcUnstableFeatureBound { attr_span, span });
             }
         }