Don't leave a comma at the start of argument list when removing arguments

WaffleLapkin · WaffleLapkin · commit b9d5a6b709be · 2023-03-30T17:26:12.000Z
diff --git a/compiler/rustc_hir_typeck/src/fn_ctxt/checks.rs b/compiler/rustc_hir_typeck/src/fn_ctxt/checks.rs
@@ -21,7 +21,7 @@ use rustc_hir_analysis::astconv::AstConv;
 use rustc_hir_analysis::check::intrinsicck::InlineAsmCtxt;
 use rustc_hir_analysis::check::potentially_plural_count;
 use rustc_hir_analysis::structured_errors::StructuredDiagnostic;
-use rustc_index::vec::IndexVec;
+use rustc_index::vec::{Idx, IndexVec};
 use rustc_infer::infer::error_reporting::{FailureCode, ObligationCauseExt};
 use rustc_infer::infer::type_variable::{TypeVariableOrigin, TypeVariableOriginKind};
 use rustc_infer::infer::TypeTrace;
@@ -31,7 +31,7 @@ use rustc_middle::ty::visit::TypeVisitableExt;
 use rustc_middle::ty::{self, IsSuggestable, Ty};
 use rustc_session::Session;
 use rustc_span::symbol::{kw, Ident};
-use rustc_span::{self, sym, Span};
+use rustc_span::{self, sym, BytePos, Span};
 use rustc_trait_selection::traits::{self, ObligationCauseCode, SelectionContext};
 
 use std::iter;
@@ -894,8 +894,13 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
         };
 
         let mut errors = errors.into_iter().peekable();
+        let mut only_extras_so_far = errors
+            .peek()
+            .map_or(false, |first| matches!(first, Error::Extra(arg_idx) if arg_idx.index() == 0));
         let mut suggestions = vec![];
         while let Some(error) = errors.next() {
+            only_extras_so_far &= matches!(error, Error::Extra(_));
+
             match error {
                 Error::Invalid(provided_idx, expected_idx, compatibility) => {
                     let (formal_ty, expected_ty) = formal_and_expected_inputs[expected_idx];
@@ -941,10 +946,37 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                         if arg_idx.index() > 0
                         && let Some((_, prev)) = provided_arg_tys
                             .get(ProvidedIdx::from_usize(arg_idx.index() - 1)
-                    ) {
-                        // Include previous comma
-                        span = prev.shrink_to_hi().to(span);
-                    }
+                        ) {
+                            // Include previous comma
+                            span = prev.shrink_to_hi().to(span);
+                        }
+
+                        // Is last argument for deletion in a row starting from the 0-th argument?
+                        // Then delete the next comma, so we are not left with `f(, ...)`
+                        //
+                        //     fn f() {}
+                        //   - f(0, 1,)
+                        //   + f()
+                        if only_extras_so_far
+                            && errors
+                                .peek()
+                                .map_or(true, |next_error| !matches!(next_error, Error::Extra(_)))
+                        {
+                            let next = provided_arg_tys
+                                .get(arg_idx.plus(1))
+                                .map(|&(_, sp)| sp)
+                                .unwrap_or_else(|| {
+                                    // Subtract one to move before `)`
+                                    call_expr
+                                        .span
+                                        .shrink_to_hi()
+                                        .with_lo(call_expr.span.hi() - BytePos(1))
+                                });
+
+                            // Include next comma
+                            span = span.until(next);
+                        }
+
                         suggestions.push((span, String::new()));
 
                         suggestion_text = match suggestion_text {
diff --git a/tests/ui/argument-suggestions/issue-109425.fixed b/tests/ui/argument-suggestions/issue-109425.fixed
@@ -0,0 +1,20 @@
+// run-rustfix
+
+fn f() {}
+fn i(_: u32) {}
+fn is(_: u32, _: &str) {}
+fn s(_: &str) {}
+
+fn main() {
+    // code             expected suggestion
+    f();        // f()
+    //~^ error: this function takes 0 arguments but 2 arguments were supplied
+    i(0,);     // i(0,)
+    //~^ error: this function takes 1 argument but 3 arguments were supplied
+    i(0);      // i(0)
+    //~^ error: this function takes 1 argument but 3 arguments were supplied
+    is(0, ""); // is(0, "")
+    //~^ error: this function takes 2 arguments but 4 arguments were supplied
+    s("");     // s("")
+    //~^ error: this function takes 1 argument but 3 arguments were supplied
+}
diff --git a/tests/ui/argument-suggestions/issue-109425.rs b/tests/ui/argument-suggestions/issue-109425.rs
@@ -1,3 +1,5 @@
+// run-rustfix
+
 fn f() {}
 fn i(_: u32) {}
 fn is(_: u32, _: &str) {}
diff --git a/tests/ui/argument-suggestions/issue-109425.stderr b/tests/ui/argument-suggestions/issue-109425.stderr
@@ -1,32 +1,32 @@
 error[E0061]: this function takes 0 arguments but 2 arguments were supplied
-  --> $DIR/issue-109425.rs:8:5
+  --> $DIR/issue-109425.rs:10:5
    |
 LL |     f(0, 1,);        // f()
    |     ^ -  - unexpected argument of type `{integer}`
    |       |
    |       unexpected argument of type `{integer}`
    |
 note: function defined here
-  --> $DIR/issue-109425.rs:1:4
+  --> $DIR/issue-109425.rs:3:4
    |
 LL | fn f() {}
    |    ^
 help: remove the extra arguments
    |
 LL -     f(0, 1,);        // f()
-LL +     f(,);        // f()
+LL +     f();        // f()
    |
 
 error[E0061]: this function takes 1 argument but 3 arguments were supplied
-  --> $DIR/issue-109425.rs:10:5
+  --> $DIR/issue-109425.rs:12:5
    |
 LL |     i(0, 1, 2,);     // i(0,)
    |     ^    -  - unexpected argument of type `{integer}`
    |          |
    |          unexpected argument of type `{integer}`
    |
 note: function defined here
-  --> $DIR/issue-109425.rs:2:4
+  --> $DIR/issue-109425.rs:4:4
    |
 LL | fn i(_: u32) {}
    |    ^ ------
@@ -37,15 +37,15 @@ LL +     i(0,);     // i(0,)
    |
 
 error[E0061]: this function takes 1 argument but 3 arguments were supplied
-  --> $DIR/issue-109425.rs:12:5
+  --> $DIR/issue-109425.rs:14:5
    |
 LL |     i(0, 1, 2);      // i(0)
    |     ^    -  - unexpected argument of type `{integer}`
    |          |
    |          unexpected argument of type `{integer}`
    |
 note: function defined here
-  --> $DIR/issue-109425.rs:2:4
+  --> $DIR/issue-109425.rs:4:4
    |
 LL | fn i(_: u32) {}
    |    ^ ------
@@ -56,15 +56,15 @@ LL +     i(0);      // i(0)
    |
 
 error[E0061]: this function takes 2 arguments but 4 arguments were supplied
-  --> $DIR/issue-109425.rs:14:5
+  --> $DIR/issue-109425.rs:16:5
    |
 LL |     is(0, 1, 2, ""); // is(0, "")
    |     ^^    -  - unexpected argument of type `{integer}`
    |           |
    |           unexpected argument of type `{integer}`
    |
 note: function defined here
-  --> $DIR/issue-109425.rs:3:4
+  --> $DIR/issue-109425.rs:5:4
    |
 LL | fn is(_: u32, _: &str) {}
    |    ^^ ------  -------
@@ -75,22 +75,22 @@ LL +     is(0, ""); // is(0, "")
    |
 
 error[E0061]: this function takes 1 argument but 3 arguments were supplied
-  --> $DIR/issue-109425.rs:16:5
+  --> $DIR/issue-109425.rs:18:5
    |
 LL |     s(0, 1, "");     // s("")
    |     ^ -  - unexpected argument of type `{integer}`
    |       |
    |       unexpected argument of type `{integer}`
    |
 note: function defined here
-  --> $DIR/issue-109425.rs:4:4
+  --> $DIR/issue-109425.rs:6:4
    |
 LL | fn s(_: &str) {}
    |    ^ -------
 help: remove the extra arguments
    |
 LL -     s(0, 1, "");     // s("")
-LL +     s(, "");     // s("")
+LL +     s("");     // s("")
    |
 
 error: aborting due to 5 previous errors
diff --git a/tests/ui/suggestions/issue-109396.stderr b/tests/ui/suggestions/issue-109396.stderr
@@ -25,7 +25,7 @@ note: function defined here
 help: remove the extra arguments
    |
 LL -             file.as_raw_fd(),
-LL +             ,
+LL +             );
    |
 
 error: aborting due to 2 previous errors

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+// run-rustfix`
	`2`	`+`
`1`	`3`	`fn f() {}`
`2`	`4`	`fn i(_: u32) {}`
`3`	`5`	`fn is(_: u32, _: &str) {}`
Original file line number	Diff line number	Diff line change
`@@ -1,32 +1,32 @@`
`1`	`1`	`error[E0061]: this function takes 0 arguments but 2 arguments were supplied`
`2`		`- --> $DIR/issue-109425.rs:8:5`
	`2`	`+ --> $DIR/issue-109425.rs:10:5`
`3`	`3`	`\|`
`4`	`4`	`LL \| f(0, 1,); // f()`
`5`	`5`	\| ^ - - unexpected argument of type `{integer}`
`6`	`6`	`\| \|`
`7`	`7`	\| unexpected argument of type `{integer}`
`8`	`8`	`\|`
`9`	`9`	`note: function defined here`
`10`		`- --> $DIR/issue-109425.rs:1:4`
	`10`	`+ --> $DIR/issue-109425.rs:3:4`
`11`	`11`	`\|`
`12`	`12`	`LL \| fn f() {}`
`13`	`13`	`\| ^`
`14`	`14`	`help: remove the extra arguments`
`15`	`15`	`\|`
`16`	`16`	`LL - f(0, 1,); // f()`
`17`		`-LL + f(,); // f()`
	`17`	`+LL + f(); // f()`
`18`	`18`	`\|`
`19`	`19`
`20`	`20`	`error[E0061]: this function takes 1 argument but 3 arguments were supplied`
`21`		`- --> $DIR/issue-109425.rs:10:5`
	`21`	`+ --> $DIR/issue-109425.rs:12:5`
`22`	`22`	`\|`
`23`	`23`	`LL \| i(0, 1, 2,); // i(0,)`
`24`	`24`	\| ^ - - unexpected argument of type `{integer}`
`25`	`25`	`\| \|`
`26`	`26`	\| unexpected argument of type `{integer}`
`27`	`27`	`\|`
`28`	`28`	`note: function defined here`
`29`		`- --> $DIR/issue-109425.rs:2:4`
	`29`	`+ --> $DIR/issue-109425.rs:4:4`
`30`	`30`	`\|`
`31`	`31`	`LL \| fn i(_: u32) {}`
`32`	`32`	`\| ^ ------`
`@@ -37,15 +37,15 @@ LL + i(0,); // i(0,)`
`37`	`37`	`\|`
`38`	`38`
`39`	`39`	`error[E0061]: this function takes 1 argument but 3 arguments were supplied`
`40`		`- --> $DIR/issue-109425.rs:12:5`
	`40`	`+ --> $DIR/issue-109425.rs:14:5`
`41`	`41`	`\|`
`42`	`42`	`LL \| i(0, 1, 2); // i(0)`
`43`	`43`	\| ^ - - unexpected argument of type `{integer}`
`44`	`44`	`\| \|`
`45`	`45`	\| unexpected argument of type `{integer}`
`46`	`46`	`\|`
`47`	`47`	`note: function defined here`
`48`		`- --> $DIR/issue-109425.rs:2:4`
	`48`	`+ --> $DIR/issue-109425.rs:4:4`
`49`	`49`	`\|`
`50`	`50`	`LL \| fn i(_: u32) {}`
`51`	`51`	`\| ^ ------`
`@@ -56,15 +56,15 @@ LL + i(0); // i(0)`
`56`	`56`	`\|`
`57`	`57`
`58`	`58`	`error[E0061]: this function takes 2 arguments but 4 arguments were supplied`
`59`		`- --> $DIR/issue-109425.rs:14:5`
	`59`	`+ --> $DIR/issue-109425.rs:16:5`
`60`	`60`	`\|`
`61`	`61`	`LL \| is(0, 1, 2, ""); // is(0, "")`
`62`	`62`	\| ^^ - - unexpected argument of type `{integer}`
`63`	`63`	`\| \|`
`64`	`64`	\| unexpected argument of type `{integer}`
`65`	`65`	`\|`
`66`	`66`	`note: function defined here`
`67`		`- --> $DIR/issue-109425.rs:3:4`
	`67`	`+ --> $DIR/issue-109425.rs:5:4`
`68`	`68`	`\|`
`69`	`69`	`LL \| fn is(_: u32, _: &str) {}`
`70`	`70`	`\| ^^ ------ -------`
`@@ -75,22 +75,22 @@ LL + is(0, ""); // is(0, "")`
`75`	`75`	`\|`
`76`	`76`
`77`	`77`	`error[E0061]: this function takes 1 argument but 3 arguments were supplied`
`78`		`- --> $DIR/issue-109425.rs:16:5`
	`78`	`+ --> $DIR/issue-109425.rs:18:5`
`79`	`79`	`\|`
`80`	`80`	`LL \| s(0, 1, ""); // s("")`
`81`	`81`	\| ^ - - unexpected argument of type `{integer}`
`82`	`82`	`\| \|`
`83`	`83`	\| unexpected argument of type `{integer}`
`84`	`84`	`\|`
`85`	`85`	`note: function defined here`
`86`		`- --> $DIR/issue-109425.rs:4:4`
	`86`	`+ --> $DIR/issue-109425.rs:6:4`
`87`	`87`	`\|`
`88`	`88`	`LL \| fn s(_: &str) {}`
`89`	`89`	`\| ^ -------`
`90`	`90`	`help: remove the extra arguments`
`91`	`91`	`\|`
`92`	`92`	`LL - s(0, 1, ""); // s("")`
`93`		`-LL + s(, ""); // s("")`
	`93`	`+LL + s(""); // s("")`
`94`	`94`	`\|`
`95`	`95`
`96`	`96`	`error: aborting due to 5 previous errors`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ note: function defined here`
`25`	`25`	`help: remove the extra arguments`
`26`	`26`	`\|`
`27`	`27`	`LL - file.as_raw_fd(),`
`28`		`-LL + ,`
	`28`	`+LL + );`
`29`	`29`	`\|`
`30`	`30`
`31`	`31`	`error: aborting due to 2 previous errors`