Use verbose format for fully-qualified path suggestion

Author: estebank

compiler/rustc_hir_typeck/src/method/suggest.rs

@@ -15,6 +15,7 @@ use rustc_data_structures::sorted_map::SortedMap;
 use rustc_data_structures::unord::UnordSet;
 use rustc_errors::{
     codes::*, pluralize, struct_span_code_err, Applicability, Diag, MultiSpan, StashKey,
+    SuggestionStyle,
 };
 use rustc_hir::def::DefKind;
 use rustc_hir::def_id::DefId;
@@ -1949,11 +1950,12 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
             && let Some(span) = sugg_span
         {
             suggs.sort();
-            err.span_suggestions(
+            err.span_suggestions_with_style(
                 span.with_hi(item_name.span.lo()),
                 "use fully-qualified syntax to disambiguate",
                 suggs,
                 Applicability::MachineApplicable,
+                SuggestionStyle::ShowAlways,
             );
         }
         if sources.len() > limit {

tests/ui/dyn-keyword/trait-dyn-in-qualified-path-with-collision.stderr

@@ -2,9 +2,7 @@ error[E0034]: multiple applicable items in scope
   --> $DIR/trait-dyn-in-qualified-path-with-collision.rs:9:18
    |
 LL |     <dyn Trait>::function(&());
-   |     -------------^^^^^^^^ multiple `function` found
-   |     |
-   |     help: use fully-qualified syntax to disambiguate: `Trait::`
+   |                  ^^^^^^^^ multiple `function` found
    |
 note: candidate #1 is defined in the trait `Trait`
   --> $DIR/trait-dyn-in-qualified-path-with-collision.rs:2:5
@@ -16,6 +14,10 @@ note: candidate #2 is defined in an impl for the type `(dyn Trait + 'static)`
    |
 LL |     fn function(&self) {}
    |     ^^^^^^^^^^^^^^^^^^
+help: use fully-qualified syntax to disambiguate
+   |
+LL |     Trait::function(&());
+   |     ~~~~~~~
 
 error: aborting due to 1 previous error