Suggest .clone() in some move errors

```
error[E0507]: cannot move out of `*x` which is behind a shared reference
  --> $DIR/borrowck-fn-in-const-a.rs:6:16
   |
LL |         return *x
   |                ^^ move occurs because `*x` has type `String`, which does not implement the `Copy` trait
   |
help: consider cloning the value if the performance cost is acceptable
   |
LL -         return *x
LL +         return x.clone()
   |
```

Author: estebank

compiler/rustc_borrowck/src/diagnostics/move_errors.rs

@@ -474,6 +474,11 @@ impl<'a, 'tcx> MirBorrowckCtxt<'a, 'tcx> {
                     Some(desc) => format!("`{desc}`"),
                     None => "value".to_string(),
                 };
+
+                if let Some(expr) = self.find_expr(span) {
+                    self.suggest_cloning(err, place_ty, expr, span);
+                }
+
                 err.subdiagnostic(
                     self.dcx(),
                     crate::session_diagnostics::TypeNoCopy::Label {
@@ -582,6 +587,11 @@ impl<'a, 'tcx> MirBorrowckCtxt<'a, 'tcx> {
 
             if binds_to.len() == 1 {
                 let place_desc = &format!("`{}`", self.local_names[*local].unwrap());
+
+                if let Some(expr) = self.find_expr(binding_span) {
+                    self.suggest_cloning(err, bind_to.ty, expr, binding_span);
+                }
+
                 err.subdiagnostic(
                     self.dcx(),
                     crate::session_diagnostics::TypeNoCopy::Label {

tests/ui/borrowck/borrowck-fn-in-const-a.stderr

@@ -3,6 +3,12 @@ error[E0507]: cannot move out of `*x` which is behind a shared reference
    |
 LL |         return *x
    |                ^^ move occurs because `*x` has type `String`, which does not implement the `Copy` trait
+   |
+help: consider cloning the value if the performance cost is acceptable
+   |
+LL -         return *x
+LL +         return x.clone()
+   |
 
 error: aborting due to 1 previous error
 

tests/ui/borrowck/borrowck-in-static.stderr

@@ -7,6 +7,11 @@ LL |     Box::new(|| x)
    |              -- ^ move occurs because `x` has type `Box<i32>`, which does not implement the `Copy` trait
    |              |
    |              captured by this `Fn` closure
+   |
+help: consider cloning the value if the performance cost is acceptable
+   |
+LL |     Box::new(|| x.clone())
+   |                  ++++++++
 
 error: aborting due to 1 previous error
 

tests/ui/borrowck/borrowck-move-out-of-overloaded-auto-deref.fixed

@@ -2,6 +2,6 @@
 use std::rc::Rc;
 
 pub fn main() {
-    let _x = <Vec<i32> as Clone>::clone(&Rc::new(vec![1, 2])).into_iter();
+    let _x = <Vec<i32> as Clone>::clone(&Rc::new(vec![1, 2]).clone()).into_iter();
     //~^ ERROR [E0507]
 }

tests/ui/borrowck/borrowck-move-out-of-overloaded-auto-deref.stderr

@@ -12,6 +12,10 @@ help: you can `clone` the value and consume it, but this might not be your desir
    |
 LL |     let _x = <Vec<i32> as Clone>::clone(&Rc::new(vec![1, 2])).into_iter();
    |              ++++++++++++++++++++++++++++                   +
+help: consider cloning the value if the performance cost is acceptable
+   |
+LL |     let _x = Rc::new(vec![1, 2]).clone().into_iter();
+   |                                 ++++++++
 
 error: aborting due to 1 previous error
 

tests/ui/borrowck/borrowck-struct-update-with-dtor.stderr

@@ -15,6 +15,11 @@ LL |     let _s2 = T{a: 2, ..s0};
    |               |
    |               cannot move out of here
    |               move occurs because `s0.mv` has type `Box<isize>`, which does not implement the `Copy` trait
+   |
+help: consider cloning the value if the performance cost is acceptable
+   |
+LL |     let _s2 = T{a: 2, ..s0}.clone();
+   |                            ++++++++
 
 error: aborting due to 2 previous errors
 

tests/ui/borrowck/clone-span-on-try-operator.fixed

@@ -7,5 +7,5 @@ impl Foo {
 }
 fn main() {
     let foo = &Foo;
-    <Foo as Clone>::clone(&(*foo)).foo(); //~ ERROR cannot move out
+    <Foo as Clone>::clone(&foo.clone()).foo(); //~ ERROR cannot move out
 }

tests/ui/borrowck/clone-span-on-try-operator.stderr

@@ -15,6 +15,11 @@ help: you can `clone` the value and consume it, but this might not be your desir
    |
 LL |     <Foo as Clone>::clone(&(*foo)).foo();
    |     +++++++++++++++++++++++      +
+help: consider cloning the value if the performance cost is acceptable
+   |
+LL -     (*foo).foo();
+LL +     foo.clone().foo();
+   |
 
 error: aborting due to 1 previous error
 

tests/ui/borrowck/issue-64453.stderr

@@ -22,6 +22,11 @@ error[E0507]: cannot move out of static item `settings_dir`
    |
 LL |     let settings_data = from_string(settings_dir);
    |                                     ^^^^^^^^^^^^ move occurs because `settings_dir` has type `String`, which does not implement the `Copy` trait
+   |
+help: consider cloning the value if the performance cost is acceptable
+   |
+LL |     let settings_data = from_string(settings_dir.clone());
+   |                                                 ++++++++
 
 error: aborting due to 3 previous errors
 

tests/ui/borrowck/move-error-in-promoted.stderr

@@ -6,6 +6,11 @@ LL |     let _ = S1(C[0]).clone();
    |                |
    |                cannot move out of here
    |                move occurs because value has type `S2`, which does not implement the `Copy` trait
+   |
+help: consider cloning the value if the performance cost is acceptable
+   |
+LL |     let _ = S1(C[0].clone()).clone();
+   |                    ++++++++
 
 error: aborting due to 1 previous error