Fix tests that fail with --emit metadata

Author: jonas-schievink

src/test/ui/associated-const/defaults-cyclic-fail.rs

@@ -1,9 +1,9 @@
-// compile-fail
+// build-fail
 
 // Cyclic assoc. const defaults don't error unless *used*
 trait Tr {
     const A: u8 = Self::B;
-    //~^ ERROR cycle detected when const-evaluating `Tr::A`
+    //~^ ERROR cycle detected when const-evaluating + checking `Tr::A`
 
     const B: u8 = Self::A;
 }

src/test/ui/associated-const/defaults-cyclic-fail.stderr

@@ -1,15 +1,25 @@
-error[E0391]: cycle detected when const-evaluating `Tr::A`
+error[E0391]: cycle detected when const-evaluating + checking `Tr::A`
+  --> $DIR/defaults-cyclic-fail.rs:5:5
+   |
+LL |     const A: u8 = Self::B;
+   |     ^^^^^^^^^^^^^^^^^^^^^^
+   |
+note: ...which requires const-evaluating `Tr::A`...
   --> $DIR/defaults-cyclic-fail.rs:5:19
    |
 LL |     const A: u8 = Self::B;
    |                   ^^^^^^^
+note: ...which requires const-evaluating + checking `Tr::B`...
+  --> $DIR/defaults-cyclic-fail.rs:8:5
    |
+LL |     const B: u8 = Self::A;
+   |     ^^^^^^^^^^^^^^^^^^^^^^
 note: ...which requires const-evaluating `Tr::B`...
   --> $DIR/defaults-cyclic-fail.rs:8:19
    |
 LL |     const B: u8 = Self::A;
    |                   ^^^^^^^
-   = note: ...which again requires const-evaluating `Tr::A`, completing the cycle
+   = note: ...which again requires const-evaluating + checking `Tr::A`, completing the cycle
 note: cycle used when const-evaluating `main`
   --> $DIR/defaults-cyclic-fail.rs:16:16
    |

src/test/ui/associated-const/defaults-not-assumed-fail.rs

@@ -1,4 +1,4 @@
-// compile-fail
+// build-fail
 
 trait Tr {
     const A: u8 = 255;