Skip to content

Commit 95364df

Browse files
estebankestebank
committed
Do not display ADT type arguments and fix rebase
1 parent db1bfbd commit 95364df

30 files changed

+106
-73
lines changed

‎src/librustc_typeck/coherence/orphan.rs‎

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -43,23 +43,28 @@ impl ItemLikeVisitor<'v> for OrphanChecker<'tcx> {
4343
);
4444
err.span_label(sp, "impl doesn't use only types from inside the current crate");
4545
for (ty, is_target_ty) in &tys {
46-
// FIXME: We want to remove the type arguments from the displayed type.
47-
// The reverse of `resolve_vars_if_possible`.
4846
let mut ty = *ty;
4947
self.tcx.infer_ctxt().enter(|infcx| {
5048
// Remove the lifetimes unnecessary for this error.
5149
ty = infcx.freshen(ty);
5250
});
53-
let msg = format!(
54-
"`{}` is not defined in the current crate{}",
55-
ty,
56-
match &ty.kind {
57-
ty::Slice(_) => " because slices are always foreign",
58-
ty::Array(..) => " because arrays are always foreign",
59-
ty::Tuple(..) => " because tuples are always foreign",
60-
_ => "",
61-
},
62-
);
51+
ty = match ty.kind {
52+
// Remove the type arguments from the output, as they are not relevant.
53+
// You can think of this as the reverse of `resolve_vars_if_possible`.
54+
// That way if we had `Vec<MyType>`, we will properly attribute the
55+
// problem to `Vec<T>` and avoid confusing the user if they were to see
56+
// `MyType` in the error.
57+
ty::Adt(def, _) => self.tcx.mk_adt(def, ty::List::empty()),
58+
_ => ty,
59+
};
60+
let this = "this".to_string();
61+
let (ty, postfix) = match &ty.kind {
62+
ty::Slice(_) => (this, " because slices are always foreign"),
63+
ty::Array(..) => (this, " because arrays are always foreign"),
64+
ty::Tuple(..) => (this, " because tuples are always foreign"),
65+
_ => (format!("`{}`", ty), ""),
66+
};
67+
let msg = format!("{} is not defined in the current crate{}", ty, postfix);
6368
if *is_target_ty {
6469
// Point at `D<A>` in `impl<A, B> for C<B> in D<A>`
6570
err.span_label(impl_ty.span, &msg);

‎src/test/ui/coherence/coherence-cow.re_a.stderr‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
44
LL | impl<T> Remote for Pair<T,Cover<T>> { }
55
| ^^^^^^^^^^^^^^^^^^^----------------
66
| | |
7-
| | `lib::Pair<T, Cover<T>>` is not defined in the current crate
7+
| | `lib::Pair` is not defined in the current crate
88
| impl doesn't use only types from inside the current crate
99
|
1010
= note: define and implement a trait or new type instead

‎src/test/ui/coherence/coherence-cow.re_b.stderr‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
44
LL | impl<T> Remote for Pair<Cover<T>,T> { }
55
| ^^^^^^^^^^^^^^^^^^^----------------
66
| | |
7-
| | `lib::Pair<Cover<T>, T>` is not defined in the current crate
7+
| | `lib::Pair` is not defined in the current crate
88
| impl doesn't use only types from inside the current crate
99
|
1010
= note: define and implement a trait or new type instead

‎src/test/ui/coherence/coherence-cow.re_c.stderr‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
44
LL | impl<T,U> Remote for Pair<Cover<T>,U> { }
55
| ^^^^^^^^^^^^^^^^^^^^^----------------
66
| | |
7-
| | `lib::Pair<Cover<T>, U>` is not defined in the current crate
7+
| | `lib::Pair` is not defined in the current crate
88
| impl doesn't use only types from inside the current crate
99
|
1010
= note: define and implement a trait or new type instead

‎src/test/ui/coherence/coherence-impls-copy.old.stderr‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
6262
LL | impl Copy for (MyType, MyType) {}
6363
| ^^^^^^^^^^^^^^----------------
6464
| | |
65-
| | `(MyType, MyType)` is not defined in the current crate because tuples are always foreign
65+
| | this is not defined in the current crate because tuples are always foreign
6666
| impl doesn't use only types from inside the current crate
6767
|
6868
= note: define and implement a trait or new type instead
@@ -73,7 +73,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
7373
LL | impl Copy for [MyType] {}
7474
| ^^^^^^^^^^^^^^--------
7575
| | |
76-
| | `[MyType]` is not defined in the current crate because slices are always foreign
76+
| | this is not defined in the current crate because slices are always foreign
7777
| impl doesn't use only types from inside the current crate
7878
|
7979
= note: define and implement a trait or new type instead
@@ -84,7 +84,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
8484
LL | impl Copy for &'static [NotSync] {}
8585
| ^^^^^^^^^^^^^^------------------
8686
| | |
87-
| | `[NotSync]` is not defined in the current crate because slices are always foreign
87+
| | this is not defined in the current crate because slices are always foreign
8888
| impl doesn't use only types from inside the current crate
8989
|
9090
= note: define and implement a trait or new type instead

‎src/test/ui/coherence/coherence-impls-copy.re.stderr‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
6262
LL | impl Copy for (MyType, MyType) {}
6363
| ^^^^^^^^^^^^^^----------------
6464
| | |
65-
| | `(MyType, MyType)` is not defined in the current crate because tuples are always foreign
65+
| | this is not defined in the current crate because tuples are always foreign
6666
| impl doesn't use only types from inside the current crate
6767
|
6868
= note: define and implement a trait or new type instead
@@ -73,7 +73,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
7373
LL | impl Copy for [MyType] {}
7474
| ^^^^^^^^^^^^^^--------
7575
| | |
76-
| | `[MyType]` is not defined in the current crate because slices are always foreign
76+
| | this is not defined in the current crate because slices are always foreign
7777
| impl doesn't use only types from inside the current crate
7878
|
7979
= note: define and implement a trait or new type instead
@@ -84,7 +84,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
8484
LL | impl Copy for &'static [NotSync] {}
8585
| ^^^^^^^^^^^^^^------------------
8686
| | |
87-
| | `[NotSync]` is not defined in the current crate because slices are always foreign
87+
| | this is not defined in the current crate because slices are always foreign
8888
| impl doesn't use only types from inside the current crate
8989
|
9090
= note: define and implement a trait or new type instead

‎src/test/ui/coherence/coherence-impls-send.old.stderr‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
44
LL | unsafe impl Send for (MyType, MyType) {}
55
| ^^^^^^^^^^^^^^^^^^^^^----------------
66
| | |
7-
| | `(MyType, MyType)` is not defined in the current crate because tuples are always foreign
7+
| | this is not defined in the current crate because tuples are always foreign
88
| impl doesn't use only types from inside the current crate
99
|
1010
= note: define and implement a trait or new type instead
@@ -21,7 +21,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
2121
LL | unsafe impl Send for [MyType] {}
2222
| ^^^^^^^^^^^^^^^^^^^^^--------
2323
| | |
24-
| | `[MyType]` is not defined in the current crate because slices are always foreign
24+
| | this is not defined in the current crate because slices are always foreign
2525
| impl doesn't use only types from inside the current crate
2626
|
2727
= note: define and implement a trait or new type instead
@@ -32,7 +32,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
3232
LL | unsafe impl Send for &'static [NotSync] {}
3333
| ^^^^^^^^^^^^^^^^^^^^^------------------
3434
| | |
35-
| | `[NotSync]` is not defined in the current crate because slices are always foreign
35+
| | this is not defined in the current crate because slices are always foreign
3636
| impl doesn't use only types from inside the current crate
3737
|
3838
= note: define and implement a trait or new type instead

‎src/test/ui/coherence/coherence-impls-send.re.stderr‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
44
LL | unsafe impl Send for (MyType, MyType) {}
55
| ^^^^^^^^^^^^^^^^^^^^^----------------
66
| | |
7-
| | `(MyType, MyType)` is not defined in the current crate because tuples are always foreign
7+
| | this is not defined in the current crate because tuples are always foreign
88
| impl doesn't use only types from inside the current crate
99
|
1010
= note: define and implement a trait or new type instead
@@ -21,7 +21,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
2121
LL | unsafe impl Send for [MyType] {}
2222
| ^^^^^^^^^^^^^^^^^^^^^--------
2323
| | |
24-
| | `[MyType]` is not defined in the current crate because slices are always foreign
24+
| | this is not defined in the current crate because slices are always foreign
2525
| impl doesn't use only types from inside the current crate
2626
|
2727
= note: define and implement a trait or new type instead
@@ -32,7 +32,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
3232
LL | unsafe impl Send for &'static [NotSync] {}
3333
| ^^^^^^^^^^^^^^^^^^^^^------------------
3434
| | |
35-
| | `[NotSync]` is not defined in the current crate because slices are always foreign
35+
| | this is not defined in the current crate because slices are always foreign
3636
| impl doesn't use only types from inside the current crate
3737
|
3838
= note: define and implement a trait or new type instead

‎src/test/ui/coherence/coherence-impls-sized.old.stderr‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
4040
LL | impl Sized for (MyType, MyType) {}
4141
| ^^^^^^^^^^^^^^^----------------
4242
| | |
43-
| | `(MyType, MyType)` is not defined in the current crate because tuples are always foreign
43+
| | this is not defined in the current crate because tuples are always foreign
4444
| impl doesn't use only types from inside the current crate
4545
|
4646
= note: define and implement a trait or new type instead
@@ -51,7 +51,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
5151
LL | impl Sized for [MyType] {}
5252
| ^^^^^^^^^^^^^^^--------
5353
| | |
54-
| | `[MyType]` is not defined in the current crate because slices are always foreign
54+
| | this is not defined in the current crate because slices are always foreign
5555
| impl doesn't use only types from inside the current crate
5656
|
5757
= note: define and implement a trait or new type instead
@@ -62,7 +62,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
6262
LL | impl Sized for &'static [NotSync] {}
6363
| ^^^^^^^^^^^^^^^------------------
6464
| | |
65-
| | `[NotSync]` is not defined in the current crate because slices are always foreign
65+
| | this is not defined in the current crate because slices are always foreign
6666
| impl doesn't use only types from inside the current crate
6767
|
6868
= note: define and implement a trait or new type instead

‎src/test/ui/coherence/coherence-impls-sized.re.stderr‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
4040
LL | impl Sized for (MyType, MyType) {}
4141
| ^^^^^^^^^^^^^^^----------------
4242
| | |
43-
| | `(MyType, MyType)` is not defined in the current crate because tuples are always foreign
43+
| | this is not defined in the current crate because tuples are always foreign
4444
| impl doesn't use only types from inside the current crate
4545
|
4646
= note: define and implement a trait or new type instead
@@ -51,7 +51,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
5151
LL | impl Sized for [MyType] {}
5252
| ^^^^^^^^^^^^^^^--------
5353
| | |
54-
| | `[MyType]` is not defined in the current crate because slices are always foreign
54+
| | this is not defined in the current crate because slices are always foreign
5555
| impl doesn't use only types from inside the current crate
5656
|
5757
= note: define and implement a trait or new type instead
@@ -62,7 +62,7 @@ error[E0117]: only traits defined in the current crate can be implemented for ar
6262
LL | impl Sized for &'static [NotSync] {}
6363
| ^^^^^^^^^^^^^^^------------------
6464
| | |
65-
| | `[NotSync]` is not defined in the current crate because slices are always foreign
65+
| | this is not defined in the current crate because slices are always foreign
6666
| impl doesn't use only types from inside the current crate
6767
|
6868
= note: define and implement a trait or new type instead

0 commit comments

Comments
 (0)