Skip to content

Commit 8edbbac

Browse files
petrochenkovpetrochenkov
committed
syntax: Remove SyntaxExtension::DeclMacro
It's a less powerful duplicate of `SyntaxExtension::NormalTT`
1 parent edb925a commit 8edbbac

File tree

9 files changed

+79
-104
lines changed

9 files changed

+79
-104
lines changed

‎src/librustc_plugin/registry.rs‎

Lines changed: 7 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ use rustc::util::nodemap::FxHashMap;
66

77
use syntax::ext::base::{SyntaxExtension, NamedSyntaxExtension, NormalTT};
88
use syntax::ext::base::MacroExpanderFn;
9+
use syntax::ext::hygiene::Transparency;
910
use syntax::symbol::{Symbol, sym};
1011
use syntax::ast;
1112
use syntax::feature_gate::AttributeType;
@@ -84,33 +85,14 @@ impl<'a> Registry<'a> {
8485
/// Register a syntax extension of any kind.
8586
///
8687
/// This is the most general hook into `libsyntax`'s expansion behavior.
87-
pub fn register_syntax_extension(&mut self, name: ast::Name, extension: SyntaxExtension) {
88+
pub fn register_syntax_extension(&mut self, name: ast::Name, mut extension: SyntaxExtension) {
8889
if name == sym::macro_rules {
8990
panic!("user-defined macros may not be named `macro_rules`");
9091
}
91-
self.syntax_exts.push((name, match extension {
92-
NormalTT {
93-
expander,
94-
def_info: _,
95-
allow_internal_unstable,
96-
allow_internal_unsafe,
97-
local_inner_macros,
98-
unstable_feature,
99-
edition,
100-
} => {
101-
let nid = ast::CRATE_NODE_ID;
102-
NormalTT {
103-
expander,
104-
def_info: Some((nid, self.krate_span)),
105-
allow_internal_unstable,
106-
allow_internal_unsafe,
107-
local_inner_macros,
108-
unstable_feature,
109-
edition,
110-
}
111-
}
112-
_ => extension,
113-
}));
92+
if let NormalTT { def_info: ref mut def_info @ None, .. } = extension {
93+
*def_info = Some((ast::CRATE_NODE_ID, self.krate_span));
94+
}
95+
self.syntax_exts.push((name, extension));
11496
}
11597

11698
/// Register a macro of the usual kind.
@@ -122,6 +104,7 @@ impl<'a> Registry<'a> {
122104
self.register_syntax_extension(Symbol::intern(name), NormalTT {
123105
expander: Box::new(expander),
124106
def_info: None,
107+
transparency: Transparency::SemiTransparent,
125108
allow_internal_unstable: None,
126109
allow_internal_unsafe: false,
127110
local_inner_macros: false,

‎src/librustc_resolve/macros.rs‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,8 +242,7 @@ impl<'a> base::Resolver for Resolver<'a> {
242242
fn check_unused_macros(&self) {
243243
for did in self.unused_macros.iter() {
244244
let id_span = match *self.macro_map[did] {
245-
SyntaxExtension::NormalTT { def_info, .. } |
246-
SyntaxExtension::DeclMacro { def_info, .. } => def_info,
245+
SyntaxExtension::NormalTT { def_info, .. } => def_info,
247246
_ => None,
248247
};
249248
if let Some((id, span)) = id_span {

‎src/librustdoc/passes/collect_intra_doc_links.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ fn macro_resolve(cx: &DocContext<'_>, path_str: &str) -> Option<Res> {
433433
if let Res::Def(DefKind::Macro(MacroKind::ProcMacroStub), _) = res {
434434
// skip proc-macro stubs, they'll cause `get_macro` to crash
435435
} else {
436-
if let SyntaxExtension::DeclMacro { .. } = *resolver.get_macro(res) {
436+
if let SyntaxExtension::NormalTT { .. } = *resolver.get_macro(res) {
437437
return Some(res.map_id(|_| panic!("unexpected id")));
438438
}
439439
}

‎src/libsyntax/ext/base.rs‎

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -579,6 +579,7 @@ pub enum SyntaxExtension {
579579
NormalTT {
580580
expander: Box<dyn TTMacroExpander + sync::Sync + sync::Send>,
581581
def_info: Option<(ast::NodeId, Span)>,
582+
transparency: Transparency,
582583
/// Whether the contents of the macro can
583584
/// directly use `#[unstable]` things.
584585
///
@@ -605,21 +606,12 @@ pub enum SyntaxExtension {
605606

606607
/// An attribute-like procedural macro that derives a builtin trait.
607608
BuiltinDerive(Box<dyn MultiItemModifier + sync::Sync + sync::Send>),
608-
609-
/// A declarative macro, e.g., `macro m() {}`.
610-
DeclMacro {
611-
expander: Box<dyn TTMacroExpander + sync::Sync + sync::Send>,
612-
def_info: Option<(ast::NodeId, Span)>,
613-
is_transparent: bool,
614-
edition: Edition,
615-
}
616609
}
617610

618611
impl SyntaxExtension {
619612
/// Returns which kind of macro calls this syntax extension.
620613
pub fn kind(&self) -> MacroKind {
621614
match *self {
622-
SyntaxExtension::DeclMacro { .. } |
623615
SyntaxExtension::NormalTT { .. } |
624616
SyntaxExtension::ProcMacro { .. } =>
625617
MacroKind::Bang,
@@ -635,19 +627,19 @@ impl SyntaxExtension {
635627

636628
pub fn default_transparency(&self) -> Transparency {
637629
match *self {
630+
SyntaxExtension::NormalTT { transparency, .. } => transparency,
638631
SyntaxExtension::ProcMacro { .. } |
639632
SyntaxExtension::AttrProcMacro(..) |
640633
SyntaxExtension::ProcMacroDerive(..) |
641-
SyntaxExtension::DeclMacro { is_transparent: false, .. } => Transparency::Opaque,
642-
SyntaxExtension::DeclMacro { is_transparent: true, .. } => Transparency::Transparent,
643-
_ => Transparency::SemiTransparent,
634+
SyntaxExtension::NonMacroAttr { .. } => Transparency::Opaque,
635+
SyntaxExtension::MultiModifier(..) |
636+
SyntaxExtension::BuiltinDerive(..) => Transparency::SemiTransparent,
644637
}
645638
}
646639

647640
pub fn edition(&self, default_edition: Edition) -> Edition {
648641
match *self {
649642
SyntaxExtension::NormalTT { edition, .. } |
650-
SyntaxExtension::DeclMacro { edition, .. } |
651643
SyntaxExtension::ProcMacro { edition, .. } |
652644
SyntaxExtension::AttrProcMacro(.., edition) |
653645
SyntaxExtension::ProcMacroDerive(.., edition) => edition,

‎src/libsyntax/ext/expand.rs‎

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -747,16 +747,6 @@ impl<'a, 'b> MacroExpander<'a, 'b> {
747747
};
748748

749749
let opt_expanded = match *ext {
750-
DeclMacro { ref expander, def_info, edition, .. } => {
751-
if let Err(dummy_span) = validate_and_set_expn_info(self, def_info.map(|(_, s)| s),
752-
None, false, false, None,
753-
edition) {
754-
dummy_span
755-
} else {
756-
kind.make_from(expander.expand(self.cx, span, mac.node.stream(), None))
757-
}
758-
}
759-
760750
NormalTT {
761751
ref expander,
762752
def_info,
@@ -765,6 +755,7 @@ impl<'a, 'b> MacroExpander<'a, 'b> {
765755
local_inner_macros,
766756
unstable_feature,
767757
edition,
758+
..
768759
} => {
769760
if let Err(dummy_span) = validate_and_set_expn_info(self, def_info.map(|(_, s)| s),
770761
allow_internal_unstable.clone(),

‎src/libsyntax/ext/tt/macro_rules.rs‎

Lines changed: 55 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ use crate::edition::Edition;
33
use crate::ext::base::{DummyResult, ExtCtxt, MacResult, SyntaxExtension};
44
use crate::ext::base::{NormalTT, TTMacroExpander};
55
use crate::ext::expand::{AstFragment, AstFragmentKind};
6+
use crate::ext::hygiene::Transparency;
67
use crate::ext::tt::macro_parser::{Success, Error, Failure};
78
use crate::ext::tt::macro_parser::{MatchedSeq, MatchedNonterminal};
89
use crate::ext::tt::macro_parser::{parse, parse_failure_msg};
@@ -374,65 +375,65 @@ pub fn compile(
374375
valid,
375376
});
376377

377-
if body.legacy {
378-
let allow_internal_unstable = attr::find_by_name(&def.attrs, sym::allow_internal_unstable)
379-
.map(|attr| attr
380-
.meta_item_list()
381-
.map(|list| list.iter()
382-
.filter_map(|it| {
383-
let name = it.ident().map(|ident| ident.name);
384-
if name.is_none() {
385-
sess.span_diagnostic.span_err(it.span(),
386-
"allow internal unstable expects feature names")
387-
}
388-
name
389-
})
390-
.collect::<Vec<Symbol>>().into()
391-
)
392-
.unwrap_or_else(|| {
393-
sess.span_diagnostic.span_warn(
394-
attr.span, "allow_internal_unstable expects list of feature names. In the \
395-
future this will become a hard error. Please use `allow_internal_unstable(\
396-
foo, bar)` to only allow the `foo` and `bar` features",
397-
);
398-
vec![sym::allow_internal_unstable_backcompat_hack].into()
378+
let transparency = if attr::contains_name(&def.attrs, sym::rustc_transparent_macro) {
379+
Transparency::Transparent
380+
} else if body.legacy {
381+
Transparency::SemiTransparent
382+
} else {
383+
Transparency::Opaque
384+
};
385+
386+
let allow_internal_unstable = attr::find_by_name(&def.attrs, sym::allow_internal_unstable)
387+
.map(|attr| attr
388+
.meta_item_list()
389+
.map(|list| list.iter()
390+
.filter_map(|it| {
391+
let name = it.ident().map(|ident| ident.name);
392+
if name.is_none() {
393+
sess.span_diagnostic.span_err(it.span(),
394+
"allow internal unstable expects feature names")
395+
}
396+
name
399397
})
400-
);
401-
let allow_internal_unsafe = attr::contains_name(&def.attrs, sym::allow_internal_unsafe);
402-
let mut local_inner_macros = false;
403-
if let Some(macro_export) = attr::find_by_name(&def.attrs, sym::macro_export) {
404-
if let Some(l) = macro_export.meta_item_list() {
405-
local_inner_macros = attr::list_contains_name(&l, sym::local_inner_macros);
406-
}
407-
}
398+
.collect::<Vec<Symbol>>().into()
399+
)
400+
.unwrap_or_else(|| {
401+
sess.span_diagnostic.span_warn(
402+
attr.span, "allow_internal_unstable expects list of feature names. In the \
403+
future this will become a hard error. Please use `allow_internal_unstable(\
404+
foo, bar)` to only allow the `foo` and `bar` features",
405+
);
406+
vec![sym::allow_internal_unstable_backcompat_hack].into()
407+
})
408+
);
408409

409-
let unstable_feature = attr::find_stability(&sess,
410-
&def.attrs, def.span).and_then(|stability| {
411-
if let attr::StabilityLevel::Unstable { issue, .. } = stability.level {
412-
Some((stability.feature, issue))
413-
} else {
414-
None
415-
}
416-
});
417-
418-
NormalTT {
419-
expander,
420-
def_info: Some((def.id, def.span)),
421-
allow_internal_unstable,
422-
allow_internal_unsafe,
423-
local_inner_macros,
424-
unstable_feature,
425-
edition,
410+
let allow_internal_unsafe = attr::contains_name(&def.attrs, sym::allow_internal_unsafe);
411+
412+
let mut local_inner_macros = false;
413+
if let Some(macro_export) = attr::find_by_name(&def.attrs, sym::macro_export) {
414+
if let Some(l) = macro_export.meta_item_list() {
415+
local_inner_macros = attr::list_contains_name(&l, sym::local_inner_macros);
426416
}
427-
} else {
428-
let is_transparent = attr::contains_name(&def.attrs, sym::rustc_transparent_macro);
417+
}
429418

430-
SyntaxExtension::DeclMacro {
431-
expander,
432-
def_info: Some((def.id, def.span)),
433-
is_transparent,
434-
edition,
419+
let unstable_feature = attr::find_stability(&sess,
420+
&def.attrs, def.span).and_then(|stability| {
421+
if let attr::StabilityLevel::Unstable { issue, .. } = stability.level {
422+
Some((stability.feature, issue))
423+
} else {
424+
None
435425
}
426+
});
427+
428+
NormalTT {
429+
expander,
430+
def_info: Some((def.id, def.span)),
431+
transparency,
432+
allow_internal_unstable,
433+
allow_internal_unsafe,
434+
local_inner_macros,
435+
unstable_feature,
436+
edition,
436437
}
437438
}
438439

‎src/libsyntax_ext/lib.rs‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ pub mod proc_macro_impl;
4242
use rustc_data_structures::sync::Lrc;
4343
use syntax::ast;
4444
use syntax::ext::base::{MacroExpanderFn, NormalTT, NamedSyntaxExtension, MultiModifier};
45+
use syntax::ext::hygiene::Transparency;
4546
use syntax::edition::Edition;
4647
use syntax::symbol::{sym, Symbol};
4748

@@ -59,6 +60,7 @@ pub fn register_builtins(resolver: &mut dyn syntax::ext::base::Resolver,
5960
NormalTT {
6061
expander: Box::new($f as MacroExpanderFn),
6162
def_info: None,
63+
transparency: Transparency::SemiTransparent,
6264
allow_internal_unstable: None,
6365
allow_internal_unsafe: false,
6466
local_inner_macros: false,
@@ -102,6 +104,7 @@ pub fn register_builtins(resolver: &mut dyn syntax::ext::base::Resolver,
102104
NormalTT {
103105
expander: Box::new(format::expand_format_args),
104106
def_info: None,
107+
transparency: Transparency::SemiTransparent,
105108
allow_internal_unstable: Some(vec![sym::fmt_internals].into()),
106109
allow_internal_unsafe: false,
107110
local_inner_macros: false,
@@ -112,6 +115,7 @@ pub fn register_builtins(resolver: &mut dyn syntax::ext::base::Resolver,
112115
NormalTT {
113116
expander: Box::new(format::expand_format_args_nl),
114117
def_info: None,
118+
transparency: Transparency::SemiTransparent,
115119
allow_internal_unstable: Some(vec![sym::fmt_internals].into()),
116120
allow_internal_unsafe: false,
117121
local_inner_macros: false,

‎src/test/run-pass-fulldeps/auxiliary/plugin-args.rs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ use syntax::ast;
1313
use syntax::ext::hygiene;
1414
use syntax::ext::build::AstBuilder;
1515
use syntax::ext::base::{TTMacroExpander, ExtCtxt, MacResult, MacEager, NormalTT};
16+
use syntax::ext::hygiene::Transparency;
1617
use syntax::print::pprust;
1718
use syntax::ptr::P;
1819
use syntax::symbol::Symbol;
@@ -43,6 +44,7 @@ pub fn plugin_registrar(reg: &mut Registry) {
4344
NormalTT {
4445
expander: Box::new(Expander { args: args, }),
4546
def_info: None,
47+
transparency: Transparency::SemiTransparent,
4648
allow_internal_unstable: None,
4749
allow_internal_unsafe: false,
4850
local_inner_macros: false,

‎src/test/ui/macros/nonterminal-matching.stderr‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
error: no rules expected the token `enum E { }`
22
--> $DIR/nonterminal-matching.rs:19:10
33
|
4+
LL | macro n(a $nt_item b) {
5+
| --------------------- when calling this macro
6+
...
47
LL | n!(a $nt_item b);
58
| ^^^^^^^^ no rules expected this token in macro call
69
...

0 commit comments

Comments
 (0)