Stabilize unrestricted_attribute_tokens

Author: petrochenkov

src/libsyntax/feature_gate.rs

@@ -440,9 +440,6 @@ declare_features! (
     // Added for testing E0705; perma-unstable.
     (active, test_2018_feature, "1.31.0", Some(0), Some(Edition::Edition2018)),
 
-    // support for arbitrary delimited token streams in non-macro attributes
-    (active, unrestricted_attribute_tokens, "1.30.0", Some(55208), None),
-
     // Allows `use x::y;` to resolve through `self::x`, not just `::x`.
     (active, uniform_paths, "1.30.0", Some(53130), None),
 
@@ -686,6 +683,8 @@ declare_features! (
     (accepted, repr_packed, "1.33.0", Some(33158), None),
     // Allows calling `const unsafe fn` inside `unsafe` blocks in `const fn` functions.
     (accepted, min_const_unsafe_fn, "1.33.0", Some(55607), None),
+    // support for arbitrary delimited token streams in non-macro attributes
+    (accepted, unrestricted_attribute_tokens, "1.33.0", Some(55208), None),
 );
 
 // If you change this, please modify `src/doc/unstable-book` as well. You must
@@ -1558,14 +1557,7 @@ impl<'a> Visitor<'a> for PostExpansionVisitor<'a> {
                 }
                 Err(mut err) => err.emit(),
             }
-            None => if !self.context.features.unrestricted_attribute_tokens {
-                // Unfortunately, `parse_meta` cannot be called speculatively
-                // because it can report errors by itself, so we have to call it
-                // only if the feature is disabled.
-                if let Err(mut err) = attr.parse_meta(self.context.parse_sess) {
-                    err.help("try enabling `#![feature(unrestricted_attribute_tokens)]`").emit()
-                }
-            }
+            None => {}
         }
     }
 

src/test/run-pass/proc-macro/derive-b.rs

@@ -1,7 +1,5 @@
 // aux-build:derive-b.rs
 
-#![feature(unrestricted_attribute_tokens)]
-
 extern crate derive_b;
 
 #[derive(Debug, PartialEq, derive_b::B, Eq, Copy, Clone)]

src/test/ui/attr-eq-token-tree.rs

@@ -1,6 +1,6 @@
 // compile-pass
 
-#![feature(custom_attribute, unrestricted_attribute_tokens)]
+#![feature(custom_attribute)]
 
 #[my_attr = !] // OK under feature gate
 fn main() {}

src/test/ui/feature-gates/feature-gate-unrestricted-attribute-tokens.rs

@@ -1,4 +1,2 @@
-#![feature(unrestricted_attribute_tokens)]
-
 #[doc = $not_there] //~ ERROR expected `]`, found `not_there`
 fn main() { }

src/test/ui/feature-gates/feature-gate-unrestricted-attribute-tokens.stderr

@@ -1,5 +1,5 @@
 error: expected `]`, found `not_there`
-  --> $DIR/macro-attribute.rs:3:10
+  --> $DIR/macro-attribute.rs:1:10
    |
 LL | #[doc = $not_there] //~ ERROR expected `]`, found `not_there`
    |          ^^^^^^^^^ expected `]`

src/test/ui/macros/macro-attribute.rs

@@ -1,5 +1,4 @@
 #![feature(marker_trait_attr)]
-#![feature(unrestricted_attribute_tokens)]
 
 #[marker(always)]
 trait Marker1 {}

src/test/ui/macros/macro-attribute.stderr

@@ -1,17 +1,17 @@
 error: attribute must be of the form `#[marker]`
-  --> $DIR/marker-attribute-with-values.rs:4:1
+  --> $DIR/marker-attribute-with-values.rs:3:1
    |
 LL | #[marker(always)]
    | ^^^^^^^^^^^^^^^^^
 
 error: attribute must be of the form `#[marker]`
-  --> $DIR/marker-attribute-with-values.rs:8:1
+  --> $DIR/marker-attribute-with-values.rs:7:1
    |
 LL | #[marker("never")]
    | ^^^^^^^^^^^^^^^^^^
 
 error: expected unsuffixed literal or identifier, found value
-  --> $DIR/marker-attribute-with-values.rs:12:10
+  --> $DIR/marker-attribute-with-values.rs:11:10
    |
 LL | #[marker(key = value)]
    |          ^^^

src/test/ui/marker_trait_attr/marker-attribute-with-values.rs

@@ -1,6 +1,4 @@
 // compile-flags: -Z parse-only
 
-#![feature(unrestricted_attribute_tokens)]
-
 #[path*] //~ ERROR expected one of `(`, `::`, `=`, `[`, `]`, or `{`, found `*`
 mod m {}